From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2057BC388F7 for ; Thu, 22 Oct 2020 12:42:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADD5122267 for ; Thu, 22 Oct 2020 12:42:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505307AbgJVMmf (ORCPT ); Thu, 22 Oct 2020 08:42:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:40420 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2505137AbgJVMmf (ORCPT ); Thu, 22 Oct 2020 08:42:35 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 17F58AD07; Thu, 22 Oct 2020 12:42:34 +0000 (UTC) Date: Thu, 22 Oct 2020 14:42:32 +0200 From: Oscar Salvador To: Vlastimil Babka Cc: Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pavel Tatashin , David Hildenbrand , Joonsoo Kim Subject: Re: [PATCH v2 5/7] mm, page_alloc: cache pageset high and batch in struct zone Message-ID: <20201022124231.GC26121@linux> References: <20201008114201.18824-1-vbabka@suse.cz> <20201008114201.18824-6-vbabka@suse.cz> <20201008123129.GC4967@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2020 at 07:55:02PM +0200, Vlastimil Babka wrote: > Right, here's updated patch: > > ----8<---- > From 6ab0f03762d122a896349d5e568f75c20875eb42 Mon Sep 17 00:00:00 2001 > From: Vlastimil Babka > Date: Mon, 7 Sep 2020 14:20:08 +0200 > Subject: [PATCH v2 5/7] mm, page_alloc: cache pageset high and batch in struct > zone > > All per-cpu pagesets for a zone use the same high and batch values, that are > duplicated there just for performance (locality) reasons. This patch adds the > same variables also to struct zone as a shared copy. > > This will be useful later for making possible to disable pcplists temporarily > by setting high value to 0, while remembering the values for restoring them > later. But we can also immediately benefit from not updating pagesets of all > possible cpus in case the newly recalculated values (after sysctl change or > memory online/offline) are actually unchanged from the previous ones. > > Signed-off-by: Vlastimil Babka > Acked-by: Michal Hocko LGTM, Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE L3