From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4A3AC388F9 for ; Tue, 27 Oct 2020 16:57:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86CE420809 for ; Tue, 27 Oct 2020 16:57:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603817860; bh=ziHfpWGkJtAsYAAN9W6J1gWsroJz1GkIxQcvWyUHlvU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=M2z2UlV0KXg9hr99E2+okUPMf2IUnEpYGMeS5WWXpW2EogLauxOKTvpmOCdnHZugv aJ1mfkJ9bqSAICROqGXDYMpqyubYTglX2B5QM4ur1AKriWRYjGZT7Bwsbm4o1UuKP8 GKpge6ik14o+uLI8xnNGGYsvCuGnYupJhQEPr6g8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1814567AbgJ0Q5g (ORCPT ); Tue, 27 Oct 2020 12:57:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:46666 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1794261AbgJ0PKv (ORCPT ); Tue, 27 Oct 2020 11:10:51 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3996A21D24; Tue, 27 Oct 2020 15:10:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603811450; bh=ziHfpWGkJtAsYAAN9W6J1gWsroJz1GkIxQcvWyUHlvU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qptyCrHLEKIPmfelStIvNUVgSP8ctGgMrLwHwm4VYx4I12JrfIzckukbVVhMZWJhO D2orvQpWhO3jo8nMYR7ebQO1mX8GzbfYmu5MIVmIsCYNIEZvniLvJKoTwkRHzlCZm9 tjOmC/uo5wrVMiML2f/QGr1d7IZ2SZdaNxGWrOaU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Michal Simek , Sasha Levin Subject: [PATCH 5.8 480/633] soc: xilinx: Fix error code in zynqmp_pm_probe() Date: Tue, 27 Oct 2020 14:53:43 +0100 Message-Id: <20201027135545.250963389@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027135522.655719020@linuxfoundation.org> References: <20201027135522.655719020@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit a6f2f0fdc73aacc6e10ae48ae78634dba26702d4 ] This should be returning PTR_ERR() but it returns IS_ERR() instead. Fixes: ffdbae28d9d1 ("drivers: soc: xilinx: Use mailbox IPI callback") Signed-off-by: Dan Carpenter Reviewed-by: Michal Simek Signed-off-by: Michal Simek Link: https://lore.kernel.org/r/20200605110020.GA978434@mwanda Signed-off-by: Sasha Levin --- drivers/soc/xilinx/zynqmp_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c index 31ff49fcd078b..c556623dae024 100644 --- a/drivers/soc/xilinx/zynqmp_power.c +++ b/drivers/soc/xilinx/zynqmp_power.c @@ -205,7 +205,7 @@ static int zynqmp_pm_probe(struct platform_device *pdev) rx_chan = mbox_request_channel_byname(client, "rx"); if (IS_ERR(rx_chan)) { dev_err(&pdev->dev, "Failed to request rx channel\n"); - return IS_ERR(rx_chan); + return PTR_ERR(rx_chan); } } else if (of_find_property(pdev->dev.of_node, "interrupts", NULL)) { irq = platform_get_irq(pdev, 0); -- 2.25.1