From: Oleg Nesterov <oleg@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Mark Mossberg <mark.mossberg@gmail.com>,
tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
linux-kernel@vger.kernel.org, hpa@zytor.com, jannh@google.com,
kyin@redhat.com
Subject: Re: [PATCH v2] x86/dumpstack: Fix misleading instruction pointer error message
Date: Tue, 3 Nov 2020 19:11:15 +0100 [thread overview]
Message-ID: <20201103181114.GC23992@redhat.com> (raw)
In-Reply-To: <20201103175237.GD4111@zn.tnic>
On 11/03, Borislav Petkov wrote:
>
> On Tue, Nov 03, 2020 at 06:47:44PM +0100, Oleg Nesterov wrote:
> > > I'm thinking this should not use the atomic variant if it can get called
> > > in !atomic context too.
> >
> > For what?
>
> I'm thinking copy_code() should not use copy_from_user_nmi() if former
> can be called in non-atomic context too.
I understand, but why do you think this makes sense?
Say, do you think it is fine to block in fuse_readpage() ?
Anyway, this is off-topic and I won't argue.
Oleg.
next prev parent reply other threads:[~2020-11-03 18:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 4:29 [PATCH v2] x86/dumpstack: Fix misleading instruction pointer error message Mark Mossberg
2020-10-02 10:26 ` [tip: x86/core] " tip-bot2 for Mark Mossberg
2020-11-03 12:50 ` [PATCH v2] " Oleg Nesterov
2020-11-03 17:15 ` Borislav Petkov
2020-11-03 17:47 ` Oleg Nesterov
2020-11-03 17:52 ` Borislav Petkov
2020-11-03 18:11 ` Oleg Nesterov [this message]
2020-11-03 18:20 ` Borislav Petkov
2020-11-16 22:01 ` Thomas Gleixner
2020-11-16 23:04 ` Andy Lutomirski
2020-11-16 23:37 ` Thomas Gleixner
2020-11-17 3:29 ` Andy Lutomirski
2020-11-17 9:54 ` Borislav Petkov
2020-11-17 17:31 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103181114.GC23992@redhat.com \
--to=oleg@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jannh@google.com \
--cc=kyin@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.mossberg@gmail.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).