From: Minchan Kim <minchan@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Harish Sriram <harish@linux.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] Revert "mm/vunmap: add cond_resched() in vunmap_pmd_range"
Date: Thu, 5 Nov 2020 09:33:54 -0800 [thread overview]
Message-ID: <20201105173354.GB387236@google.com> (raw)
In-Reply-To: <20201105171602.GP17076@casper.infradead.org>
On Thu, Nov 05, 2020 at 05:16:02PM +0000, Matthew Wilcox wrote:
> On Thu, Nov 05, 2020 at 09:02:49AM -0800, Minchan Kim wrote:
> > This reverts commit e47110e90584a22e9980510b00d0dfad3a83354e.
> >
> > While I was doing zram testing, I found sometimes decompression failed
> > since the compression buffer was corrupted. With investigation,
> > I found below commit calls cond_resched unconditionally so it could
> > make a problem in atomic context if the task is reschedule.
>
> I don't think you're supposed to call unmap_kernel_range() from
> atomic context. At least vfree() punts to __vfree_deferred() if
> in_interrupt() is true. I forget the original reason for why that is.
It would be desirable, However, the logic was there for several years
and made regression from the commit in stable kernel for now.
Can't we have graceful shutdown if we want to deprecate the API usecase
in atomic context?
next prev parent reply other threads:[~2020-11-05 17:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 17:02 [PATCH] Revert "mm/vunmap: add cond_resched() in vunmap_pmd_range" Minchan Kim
2020-11-05 17:16 ` Matthew Wilcox
2020-11-05 17:33 ` Minchan Kim [this message]
2020-11-07 1:59 ` Andrew Morton
2020-11-07 8:39 ` Minchan Kim
2020-11-09 11:33 ` Uladzislau Rezki
2020-11-12 20:01 ` Minchan Kim
2020-11-12 22:49 ` Andrew Morton
2020-11-13 16:25 ` Minchan Kim
2020-11-16 17:53 ` Minchan Kim
2020-11-16 23:20 ` Andrew Morton
2020-11-17 13:57 ` Uladzislau Rezki
2020-11-17 13:56 ` Christoph Hellwig
2020-11-17 20:29 ` Minchan Kim
2020-11-18 2:06 ` Sergey Senozhatsky
2020-11-19 9:29 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105173354.GB387236@google.com \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=harish@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).