From: Nathan Chancellor <natechancellor@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Abbott Liu" <liuwenliang@huawei.com>,
"Ahmad Fatoum" <a.fatoum@pengutronix.de>,
"Andrey Ryabinin" <aryabinin@virtuozzo.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Joe Perches" <joe@perches.com>,
"Russell King" <linux@armlinux.org.uk>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
linux-mm@kvack.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Nathan Chancellor" <natechancellor@gmail.com>,
"Naresh Kamboju" <naresh.kamboju@linaro.org>,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Subject: [PATCH] ARM: boot: Quote aliased symbol names in string.c
Date: Sun, 8 Nov 2020 17:17:13 -0700 [thread overview]
Message-ID: <20201109001712.3384097-1-natechancellor@gmail.com> (raw)
In-Reply-To: <20201108222156.GA1049451@ubuntu-m3-large-x86>
Patch "treewide: Remove stringification from __alias macro definition"
causes arguments to __alias to no longer be quoted automatically, which
breaks CONFIG_KASAN on ARM after commit d6d51a96c7d6 ("ARM: 9014/2:
Replace string mem* functions for KASan"):
arch/arm/boot/compressed/string.c:24:1: error: attribute 'alias' argument not a string
24 | void *__memcpy(void *__dest, __const void *__src, size_t __n) __alias(memcpy);
| ^~~~
arch/arm/boot/compressed/string.c:25:1: error: attribute 'alias' argument not a string
25 | void *__memmove(void *__dest, __const void *__src, size_t count) __alias(memmove);
| ^~~~
arch/arm/boot/compressed/string.c:26:1: error: attribute 'alias' argument not a string
26 | void *__memset(void *s, int c, size_t count) __alias(memset);
| ^~~~
make[3]: *** [scripts/Makefile.build:283: arch/arm/boot/compressed/string.o] Error 1
Quote the names like the treewide patch does so there is no more error.
Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Reported-by: Valdis Klētnieks <valdis.kletnieks@vt.edu>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
Hi Andrew,
Stephen said I should send this along to you so that it can be applied
as part of the post -next series. Please let me know if you need any
more information or clarification, I tried to document it succinctly in
the commit message.
Cheers,
Nathan
arch/arm/boot/compressed/string.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/compressed/string.c b/arch/arm/boot/compressed/string.c
index 8c0fa276d994..cc6198f8a348 100644
--- a/arch/arm/boot/compressed/string.c
+++ b/arch/arm/boot/compressed/string.c
@@ -21,9 +21,9 @@
#undef memcpy
#undef memmove
#undef memset
-void *__memcpy(void *__dest, __const void *__src, size_t __n) __alias(memcpy);
-void *__memmove(void *__dest, __const void *__src, size_t count) __alias(memmove);
-void *__memset(void *s, int c, size_t count) __alias(memset);
+void *__memcpy(void *__dest, __const void *__src, size_t __n) __alias("memcpy");
+void *__memmove(void *__dest, __const void *__src, size_t count) __alias("memmove");
+void *__memset(void *s, int c, size_t count) __alias("memset");
#endif
void *memcpy(void *__dest, __const void *__src, size_t __n)
--
2.29.2
next prev parent reply other threads:[~2020-11-09 0:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 18:33 next-20201105 - build issue with KASAN on ARM Valdis Klētnieks
2020-11-07 20:04 ` Nathan Chancellor
2020-11-08 22:19 ` Stephen Rothwell
2020-11-08 22:21 ` Nathan Chancellor
2020-11-09 0:17 ` Nathan Chancellor [this message]
2020-11-09 7:40 ` [PATCH] ARM: boot: Quote aliased symbol names in string.c Ard Biesheuvel
2020-11-09 16:04 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109001712.3384097-1-natechancellor@gmail.com \
--to=natechancellor@gmail.com \
--cc=a.fatoum@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=aryabinin@virtuozzo.com \
--cc=f.fainelli@gmail.com \
--cc=joe@perches.com \
--cc=kasan-dev@googlegroups.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=liuwenliang@huawei.com \
--cc=naresh.kamboju@linaro.org \
--cc=sfr@canb.auug.org.au \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).