From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
David Laight <David.Laight@aculab.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v3 0/7] gpio: exar: refactor the driver
Date: Tue, 10 Nov 2020 13:33:59 +0100 [thread overview]
Message-ID: <20201110123406.3261-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
I just wanted to convert the driver to using simpler IDA API but ended up
quickly converting it to using regmap. Unfortunately I don't have the HW
to test it so marking the patches that introduce functional change as RFT
and Cc'ing the original author.
v1 -> v2:
- add new regmap helper: regmap_assign_bits()
- fix lvl vs sel register access
- set value in direction_output callback
v2 -> v3:
- drop the regmap helper from series
Note: I didn't use the fancy method of offset calculation Andy and David
suggested because this series broke the driver according to Jan - let's
get it right before we modify it any more. I found a couple problems that
could maybe cause the crash. Jan: could you give it another spin?
Bartosz Golaszewski (7):
gpio: exar: add a newline after the copyright notice
gpio: exar: include idr.h
gpio: exar: switch to a simpler IDA interface
gpio: exar: use a helper variable for &pdev->dev
gpio: exar: unduplicate address and offset computation
gpio: exar: switch to using regmap
gpio: exar: use devm action for freeing the IDA and drop remove()
drivers/gpio/Kconfig | 1 +
drivers/gpio/gpio-exar.c | 154 +++++++++++++++++++--------------------
2 files changed, 77 insertions(+), 78 deletions(-)
--
2.29.1
next reply other threads:[~2020-11-10 12:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 12:33 Bartosz Golaszewski [this message]
2020-11-10 12:34 ` [PATCH v3 1/7] gpio: exar: add a newline after the copyright notice Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 2/7] gpio: exar: include idr.h Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 3/7] gpio: exar: switch to a simpler IDA interface Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 4/7] gpio: exar: use a helper variable for &pdev->dev Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 5/7] gpio: exar: unduplicate address and offset computation Bartosz Golaszewski
2020-11-10 12:34 ` [PATCH v3 6/7] gpio: exar: switch to using regmap Bartosz Golaszewski
2020-11-10 13:23 ` Jan Kiszka
2020-11-10 13:29 ` Bartosz Golaszewski
2020-11-10 13:51 ` Jan Kiszka
2020-11-10 14:11 ` Andy Shevchenko
2020-11-10 14:24 ` Bartosz Golaszewski
2020-11-10 14:26 ` Andy Shevchenko
2020-11-10 14:27 ` Andy Shevchenko
2020-11-10 14:30 ` Bartosz Golaszewski
2020-11-10 14:50 ` Jan Kiszka
2020-11-10 14:52 ` Bartosz Golaszewski
2020-11-10 15:01 ` Andy Shevchenko
2020-11-10 12:34 ` [PATCH v3 7/7] gpio: exar: use devm action for freeing the IDA and drop remove() Bartosz Golaszewski
-- strict thread matches above, loose matches on Subject: below --
2020-11-10 12:33 [PATCH v3 0/7] gpio: exar: refactor the driver Bartosz Golaszewski
2020-11-10 12:34 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201110123406.3261-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=David.Laight@aculab.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=jan.kiszka@siemens.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).