From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org
Subject: [PATCH 01/30] drm/savage/savage_bci: Remove set but never used 'aper_rsrc' and 'fb_rsrc'
Date: Thu, 12 Nov 2020 19:00:10 +0000 [thread overview]
Message-ID: <20201112190039.2785914-2-lee.jones@linaro.org> (raw)
In-Reply-To: <20201112190039.2785914-1-lee.jones@linaro.org>
The comment about them (also removed) says:
/* fb_rsrc and aper_rsrc aren't really used currently, but still exist
* in case we decide we need information on the BAR for BSD in the
* future.
*/
Well that was written 12 years ago in 2008. We are now in the future
and they are still superfluous. We can always add them again at a
later date if they are ever required.
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/savage/savage_bci.c: In function ‘savage_driver_firstopen’:
drivers/gpu/drm/savage/savage_bci.c:580:24: warning: variable ‘aper_rsrc’ set but not used [-Wunused-but-set-variable]
drivers/gpu/drm/savage/savage_bci.c:580:15: warning: variable ‘fb_rsrc’ set but not used [-Wunused-but-set-variable]
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/gpu/drm/savage/savage_bci.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
index 6889d6534ebab..606e5b807a6e7 100644
--- a/drivers/gpu/drm/savage/savage_bci.c
+++ b/drivers/gpu/drm/savage/savage_bci.c
@@ -573,19 +573,12 @@ int savage_driver_firstopen(struct drm_device *dev)
{
drm_savage_private_t *dev_priv = dev->dev_private;
unsigned long mmio_base, fb_base, fb_size, aperture_base;
- /* fb_rsrc and aper_rsrc aren't really used currently, but still exist
- * in case we decide we need information on the BAR for BSD in the
- * future.
- */
- unsigned int fb_rsrc, aper_rsrc;
int ret = 0;
if (S3_SAVAGE3D_SERIES(dev_priv->chipset)) {
- fb_rsrc = 0;
fb_base = pci_resource_start(dev->pdev, 0);
fb_size = SAVAGE_FB_SIZE_S3;
mmio_base = fb_base + SAVAGE_FB_SIZE_S3;
- aper_rsrc = 0;
aperture_base = fb_base + SAVAGE_APERTURE_OFFSET;
/* this should always be true */
if (pci_resource_len(dev->pdev, 0) == 0x08000000) {
@@ -607,10 +600,8 @@ int savage_driver_firstopen(struct drm_device *dev)
} else if (dev_priv->chipset != S3_SUPERSAVAGE &&
dev_priv->chipset != S3_SAVAGE2000) {
mmio_base = pci_resource_start(dev->pdev, 0);
- fb_rsrc = 1;
fb_base = pci_resource_start(dev->pdev, 1);
fb_size = SAVAGE_FB_SIZE_S4;
- aper_rsrc = 1;
aperture_base = fb_base + SAVAGE_APERTURE_OFFSET;
/* this should always be true */
if (pci_resource_len(dev->pdev, 1) == 0x08000000) {
@@ -626,10 +617,8 @@ int savage_driver_firstopen(struct drm_device *dev)
}
} else {
mmio_base = pci_resource_start(dev->pdev, 0);
- fb_rsrc = 1;
fb_base = pci_resource_start(dev->pdev, 1);
fb_size = pci_resource_len(dev->pdev, 1);
- aper_rsrc = 2;
aperture_base = pci_resource_start(dev->pdev, 2);
/* Automatic MTRR setup will do the right thing. */
}
--
2.25.1
next prev parent reply other threads:[~2020-11-12 19:00 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 19:00 [PATCH 00/30] [Set 6] Rid W=1 warnings from GPU Lee Jones
2020-11-12 19:00 ` Lee Jones [this message]
2020-11-12 19:31 ` [PATCH 01/30] drm/savage/savage_bci: Remove set but never used 'aper_rsrc' and 'fb_rsrc' Sam Ravnborg
2020-11-12 20:08 ` Lee Jones
2020-11-12 19:00 ` [PATCH 02/30] include: drm: drm_atomic: Artificially use 'crtc' to avoid 'not used' warning Lee Jones
2020-11-12 20:25 ` Sam Ravnborg
2020-11-13 20:49 ` Daniel Vetter
[not found] ` <CAF2Aj3j6+fEFS66qg-a-0Z1XtNQ7EAEnu4ECZ9gLiH7buH=PLw@mail.gmail.com>
2020-11-13 21:31 ` Daniel Vetter
[not found] ` <CAF2Aj3jRFM95R7VaV_4Chi3Tr3ja31EjdVTeHeDkUWETweqCGA@mail.gmail.com>
2020-11-17 10:05 ` Daniel Vetter
2020-11-17 10:34 ` Lee Jones
2020-11-17 10:43 ` Daniel Vetter
2020-11-17 11:08 ` Lee Jones
2020-11-16 17:33 ` Lee Jones
2020-11-12 19:00 ` [PATCH 03/30] drm/v3d/v3d_gem: Provide descriptions for 'v3d_lookup_bos's params Lee Jones
2020-11-12 19:00 ` [PATCH 04/30] drm/via/via_dma: Remove set but unused variable 'agp_base' Lee Jones
2020-11-12 20:27 ` Sam Ravnborg
2020-11-12 19:00 ` [PATCH 05/30] drm/v3d/v3d_sched: Demote non-conformant kernel-doc header Lee Jones
2020-11-12 19:00 ` [PATCH 06/30] drm/amd/amdgpu/amdgpu_kms: Fix misnaming of parameter 'dev' Lee Jones
2020-11-12 21:08 ` Alex Deucher
2020-11-12 19:00 ` [PATCH 07/30] drm/amd/amdgpu/amdgpu_fence: Fix some issues pertaining to function documentation Lee Jones
2020-11-12 21:11 ` Alex Deucher
2020-11-12 19:00 ` [PATCH 08/30] drm/exynos/exynos7_drm_decon: Supply missing description for param 'ctx' Lee Jones
2020-11-12 19:00 ` [PATCH 09/30] drm/exynos/exynos_drm_fimd: Add " Lee Jones
2020-11-12 19:00 ` [PATCH 10/30] drm/vc4/vc4_hdmi_regs: Mark some data sets as __maybe_unused Lee Jones
2020-11-12 19:00 ` [PATCH 11/30] drm/vc4/vc4_hdmi: Remove set but unused variable 'ret' Lee Jones
2020-11-12 19:00 ` [PATCH 12/30] drm/amd/amdgpu/amdgpu_ttm: Demote non-conformant kernel-doc headers, fix slightly lacking ones Lee Jones
2020-11-12 21:22 ` Alex Deucher
2020-11-12 19:00 ` [PATCH 13/30] drm/atmel-hlcdc/atmel_hlcdc_crtc: Apply correct formatting to struct docs Lee Jones
2020-11-12 19:29 ` Sam Ravnborg
2020-11-12 19:00 ` [PATCH 14/30] drm/amd/amdgpu/amdgpu_ring: Fix a bunch of function misdocumentation Lee Jones
2020-11-12 21:25 ` Alex Deucher
2020-11-12 19:00 ` [PATCH 15/30] drm/amd/amdgpu/amdgpu_display: Remove pointless header Lee Jones
2020-11-12 21:26 ` Alex Deucher
2020-11-12 19:00 ` [PATCH 16/30] drm/atmel-hlcdc/atmel_hlcdc_plane: Staticise local function 'atmel_hlcdc_plane_setup_scaler()' Lee Jones
2020-11-12 19:29 ` Sam Ravnborg
2020-11-12 19:00 ` [PATCH 17/30] drm/atmel-hlcdc/atmel_hlcdc_plane: Fix documentation formatting and add missing description Lee Jones
2020-11-12 19:29 ` Sam Ravnborg
2020-11-12 19:00 ` [PATCH 18/30] drm/vc4/vc4_v3d: Demote non-conformant kernel-doc headers Lee Jones
2020-11-12 19:00 ` [PATCH 19/30] drm/amd/amdgpu/amdgpu_cs: Add a couple of missing function param descriptions Lee Jones
2020-11-12 21:28 ` Alex Deucher
2020-11-12 19:00 ` [PATCH 20/30] drm/armada/armada_overlay: Staticify local function 'armada_overlay_duplicate_state' Lee Jones
2020-11-12 19:00 ` [PATCH 21/30] drm/vc4/vc4_debugfs: Demote non-conformant kernel-doc headers Lee Jones
2020-11-12 19:00 ` [PATCH 22/30] drm/rockchip/dw-mipi-dsi-rockchip: " Lee Jones
2020-11-12 19:00 ` [PATCH 23/30] drm/rockchip/rockchip_rgb: Consume our own header Lee Jones
2020-11-12 19:00 ` [PATCH 24/30] drm/nouveau/nvkm/core/firmware: Fix formatting, provide missing param description Lee Jones
2020-11-12 19:00 ` [PATCH 25/30] drm/rockchip/rockchip_lvds: Fix struct document formatting Lee Jones
2020-11-12 19:00 ` [PATCH 26/30] drm/exynos/exynos_drm_gsc: Supply missing description for 'num_limits' Lee Jones
2020-11-12 19:00 ` [PATCH 27/30] drm/sti/sti_hdmi: Move 'colorspace_mode_names' array to where its used Lee Jones
2020-11-12 20:22 ` Sam Ravnborg
2020-11-12 19:00 ` [PATCH 28/30] drm/mediatek/mtk_disp_color: Fix formatting and provide missing member description Lee Jones
2020-11-23 14:31 ` Chun-Kuang Hu
2020-11-12 19:00 ` [PATCH 29/30] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level' Lee Jones
2020-11-12 21:31 ` Alex Deucher
2020-11-12 22:10 ` Lee Jones
2020-11-12 19:00 ` [PATCH 30/30] drm/mediatek/mtk_disp_ovl: Fix formatting and provide missing member description Lee Jones
2020-11-23 14:29 ` Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112190039.2785914-2-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).