From: Nathan Chancellor <natechancellor@gmail.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Maciej Sosnowski <maciej.sosnowski@intel.com>,
Vinod Koul <vkoul@kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, Tom Rix <trix@redhat.com>,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com,
kernel-janitors@vger.kernel.org, linux-safety@lists.elisa.tech,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: ioatdma: remove unused function missed during dma_v2 removal
Date: Fri, 13 Nov 2020 11:33:54 -0700 [thread overview]
Message-ID: <20201113183354.GA1435913@ubuntu-m3-large-x86> (raw)
In-Reply-To: <20201113081248.26416-1-lukas.bulwahn@gmail.com>
On Fri, Nov 13, 2020 at 09:12:48AM +0100, Lukas Bulwahn wrote:
> Commit 7f832645d0e5 ("dmaengine: ioatdma: remove ioatdma v2 registration")
> missed to remove dca2_tag_map_valid() during its removal. Hence, since
> then, dca2_tag_map_valid() is unused and make CC=clang W=1 warns:
>
> drivers/dma/ioat/dca.c:44:19:
> warning: unused function 'dca2_tag_map_valid' [-Wunused-function]
>
> So, remove this unused function and get rid of a -Wused-function warning.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> applies cleanly on current master and next-20201112
>
> Maciej, please ack.
>
> Vinod, Dan, please pick this minor non-urgent clean-up patch.
>
> drivers/dma/ioat/dca.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/dma/ioat/dca.c b/drivers/dma/ioat/dca.c
> index 0be385587c4c..289c59ed74b9 100644
> --- a/drivers/dma/ioat/dca.c
> +++ b/drivers/dma/ioat/dca.c
> @@ -40,16 +40,6 @@
> #define DCA2_TAG_MAP_BYTE3 0x82
> #define DCA2_TAG_MAP_BYTE4 0x82
>
> -/* verify if tag map matches expected values */
> -static inline int dca2_tag_map_valid(u8 *tag_map)
> -{
> - return ((tag_map[0] == DCA2_TAG_MAP_BYTE0) &&
> - (tag_map[1] == DCA2_TAG_MAP_BYTE1) &&
> - (tag_map[2] == DCA2_TAG_MAP_BYTE2) &&
> - (tag_map[3] == DCA2_TAG_MAP_BYTE3) &&
> - (tag_map[4] == DCA2_TAG_MAP_BYTE4));
> -}
> -
> /*
> * "Legacy" DCA systems do not implement the DCA register set in the
> * I/OAT device. Software needs direct support for their tag mappings.
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-11-13 18:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 8:12 [PATCH] dmaengine: ioatdma: remove unused function missed during dma_v2 removal Lukas Bulwahn
2020-11-13 18:33 ` Nathan Chancellor [this message]
2020-11-16 17:12 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201113183354.GA1435913@ubuntu-m3-large-x86 \
--to=natechancellor@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-safety@lists.elisa.tech \
--cc=lukas.bulwahn@gmail.com \
--cc=maciej.sosnowski@intel.com \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).