From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: kieran.bingham+renesas@ideasonboard.com,
laurent.pinchart+renesas@ideasonboard.com,
niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, Hyun Kwon <hyunk@xilinx.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
sergei.shtylyov@gmail.com
Subject: [PATCH v5 5/8] media: i2c: max9286: Configure reverse channel amplitude
Date: Mon, 16 Nov 2020 14:53:02 +0100 [thread overview]
Message-ID: <20201116135305.81319-6-jacopo+renesas@jmondi.org> (raw)
In-Reply-To: <20201116135305.81319-1-jacopo+renesas@jmondi.org>
Adjust the initial reverse channel amplitude parsing from
firmware interface the 'maxim,initial-reverse-channel-mV'
property.
This change is required for both rdacm20 and rdacm21 camera
modules to be correctly probed when used in combination with
the max9286 deserializer.
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
drivers/media/i2c/max9286.c | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index 31e27d0f34f1..11ba047f3793 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -163,6 +163,8 @@ struct max9286_priv {
unsigned int mux_channel;
bool mux_open;
+ u32 reverse_channel_mV;
+
struct v4l2_ctrl_handler ctrls;
struct v4l2_ctrl *pixelrate;
@@ -557,10 +559,14 @@ static int max9286_notify_bound(struct v4l2_async_notifier *notifier,
* All enabled sources have probed and enabled their reverse control
* channels:
*
+ * - Increase the reverse channel amplitude to compensate for the
+ * remote ends high threshold, if not done already
* - Verify all configuration links are properly detected
* - Disable auto-ack as communication on the control channel are now
* stable.
*/
+ if (priv->reverse_channel_mV < 170)
+ max9286_reverse_channel_setup(priv, 170);
max9286_check_config_link(priv, priv->source_mask);
/*
@@ -967,7 +973,7 @@ static int max9286_setup(struct max9286_priv *priv)
* only. This should be disabled after the mux is initialised.
*/
max9286_configure_i2c(priv, true);
- max9286_reverse_channel_setup(priv, 170);
+ max9286_reverse_channel_setup(priv, priv->reverse_channel_mV);
/*
* Enable GMSL links, mask unused ones and autodetect link
@@ -1235,6 +1241,18 @@ static int max9286_parse_dt(struct max9286_priv *priv)
}
of_node_put(node);
+ /*
+ * Parse the initial value of the reverse channel amplitude from
+ * the firmware interface.
+ *
+ * Default it to 170mV for backward compatibility with DTB that do not
+ * provide the property.
+ */
+ if (of_property_read_u32(dev->of_node,
+ "maxim,initial-reverse-channel-mV",
+ &priv->reverse_channel_mV))
+ priv->reverse_channel_mV = 170;
+
priv->route_mask = priv->source_mask;
return 0;
--
2.29.1
next prev parent reply other threads:[~2020-11-16 13:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 13:52 [PATCH v5 0/8] media: i2c: Add RDACM21 camera module Jacopo Mondi
2020-11-16 13:52 ` [PATCH v5 1/8] media: i2c: Add driver for " Jacopo Mondi
2020-11-16 14:47 ` Kieran Bingham
2020-11-17 13:36 ` Jacopo Mondi
2020-11-17 15:31 ` Kieran Bingham
2020-11-19 14:42 ` Jacopo Mondi
2020-11-16 13:52 ` [PATCH v5 2/8] dt-bindings: media: max9286: Document 'maxim,initial-reverse-channel-mV' Jacopo Mondi
2020-11-30 22:00 ` Rob Herring
2020-12-15 11:14 ` Jacopo Mondi
2020-12-15 11:44 ` Geert Uytterhoeven
2020-12-15 12:08 ` Jacopo Mondi
2020-12-15 13:49 ` Rob Herring
2020-11-16 13:53 ` [PATCH v5 3/8] media: i2c: max9286: Break-out reverse channel setup Jacopo Mondi
2020-11-16 13:53 ` [PATCH v5 4/8] media: i2c: max9286: Make channel amplitude programmable Jacopo Mondi
2020-11-16 13:53 ` Jacopo Mondi [this message]
2020-11-16 13:53 ` [PATCH v5 6/8] arm64: dts: renesas: salvator-x: Add MAX9286 expansion board Jacopo Mondi
2020-11-16 13:53 ` [PATCH v5 7/8] [DNI] arm64: dts: renesas: salvator-x-max9286: Specify channel amplitude Jacopo Mondi
2020-11-18 13:40 ` Kieran Bingham
2020-11-16 13:53 ` [PATCH v5 8/8] [DNI] arm64: dts: renesas: eagle: " Jacopo Mondi
2020-11-18 13:34 ` [PATCH v5 0/8] media: i2c: Add RDACM21 camera module Kieran Bingham
2020-11-19 14:38 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116135305.81319-6-jacopo+renesas@jmondi.org \
--to=jacopo+renesas@jmondi.org \
--cc=geert@linux-m68k.org \
--cc=hyunk@xilinx.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).