From: Hui Su <sh_def@163.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru()
Date: Wed, 18 Nov 2020 02:05:26 +0800 [thread overview]
Message-ID: <20201117180526.GA158333@rlk> (raw)
In-Reply-To: <20201117175900.GS29991@casper.infradead.org>
On Tue, Nov 17, 2020 at 05:59:00PM +0000, Matthew Wilcox wrote:
> On Wed, Nov 18, 2020 at 01:56:58AM +0800, Hui Su wrote:
> > On Tue, Nov 17, 2020 at 05:47:27PM +0000, Matthew Wilcox wrote:
> > > On Wed, Nov 18, 2020 at 01:46:33AM +0800, Hui Su wrote:
> > > > On Tue, Nov 17, 2020 at 05:41:17PM +0000, Matthew Wilcox wrote:
> > > > > On Wed, Nov 18, 2020 at 01:12:42AM +0800, Hui Su wrote:
> > > > > > lru_list lru bit 0 can tell whether the list is
> > > > > > avtive lru-list or not.
> > > > > > lru_list lru bit 1 can tell whether the list is
> > > > > > file lru-list or not.
> > > > > >
> > > > > > And fix some define type in shrink_active_list()
> > > > > > and get_scan_count().
> > > > > >
> > > > > > v1->v2:
> > > > > > correct the commit message, and fix the define type.
> > > > >
> > > > > No, still incorrect.
> > > >
> > > > I am a little confused, can you tell in detail?
> > >
> > > Have you booted a kernel with this change? Have you run any kind of
> > > tests on it?
> >
> > Yes, I boot it with qemu-system-x86_64-4.1.50 on ubuntu20.04:
> > qemu-system-x86_64 -kernel /home/rlk/workspace/compile/out/arch/x86_64/boot/bzImage -hda \
> > /home/rlk/myspace/qemu_build/rootfs.img -append "root=/dev/sda console=ttyS0" -nographic
> >
> > using the kernel compiled with ubuntu20.04's default .config.
> >
> > It seems nothing abnormal.
> > And i did not do other test.
>
> Maybe you should ... how about LTP? I think that's pretty straightforward
> to set up and run.
Thanks for your advice, Matthew.
I will set up an ltp test envirment, thanks again.
And Please ignore this change for now.
next prev parent reply other threads:[~2020-11-17 18:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 17:12 [PATCH] mm/lru: simplify is_file_lru() and is_active_lru() Hui Su
2020-11-17 17:41 ` Matthew Wilcox
2020-11-17 17:46 ` Hui Su
2020-11-17 17:47 ` Matthew Wilcox
2020-11-17 17:56 ` Hui Su
2020-11-17 17:59 ` Matthew Wilcox
2020-11-17 18:05 ` Hui Su [this message]
2020-11-20 19:08 ` Hui Su
-- strict thread matches above, loose matches on Subject: below --
2020-11-17 16:49 Hui Su
2020-11-17 16:53 ` Hui Su
2020-11-17 17:40 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117180526.GA158333@rlk \
--to=sh_def@163.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).