linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER
Date: Thu, 19 Nov 2020 21:21:22 -0800	[thread overview]
Message-ID: <20201119212122.665d5396@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <221941d6-2bb1-9be8-7031-08071a509542@gmail.com>

On Thu, 19 Nov 2020 23:09:52 +0100 Heiner Kallweit wrote:
> Am 19.11.2020 um 22:41 schrieb Andrew Lunn:
> >>>> Doesn't checkpatch complain about line length > 80 here?  
> >>>
> >>> :)
> >>>
> >>> commit bdc48fa11e46f867ea4d75fa59ee87a7f48be144
> >>> Author: Joe Perches <joe@perches.com>
> >>> Date:   Fri May 29 16:12:21 2020 -0700
> >>>
> >>>     checkpatch/coding-style: deprecate 80-column warning
> >>>  
> >>
> >> Ah, again something learnt. Thanks for the reference.  
> > 
> > But it then got revoked for netdev. Or at least it was planned to
> > re-impose 80 for netdev. I don't know if checkpatch got patched yet.

FWIW I had a patch for it but before I sent it Dave suggested I ask
around and Alexei was opposed.

And I don't have the strength to argue :)

I'll just tell people case by case when they have 4+ indentation levels
in their code or use 40+ character variables/defines, in my copious
spare time. 

> At a first glance it sounds strange that subsystems may define own
> rules for such basic things. But supposedly there has been a longer
> emotional disucssion about this already ..

We do have our own comment style rule in networking since the beginning
of time, and reverse xmas tree, so it's not completely crazy.

  reply	other threads:[~2020-11-20  5:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 20:34 [PATCH v2] mdio_bus: suppress err message for reset gpio EPROBE_DEFER Grygorii Strashko
2020-11-19 21:11 ` Heiner Kallweit
2020-11-19 21:17   ` Grygorii Strashko
2020-11-19 21:23     ` Heiner Kallweit
2020-11-19 21:41       ` Andrew Lunn
2020-11-19 22:09         ` Heiner Kallweit
2020-11-20  5:21           ` Jakub Kicinski [this message]
2020-11-20  7:06             ` Joe Perches
2020-11-20 14:50               ` Andrew Lunn
2020-11-21  3:12 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119212122.665d5396@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=grygorii.strashko@ti.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).