From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bongsu Jeon <bongsu.jeon2@gmail.com>
Cc: linux-nfc@lists.01.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Bongsu Jeon <bongsu.jeon@samsung.com>
Subject: Re: [PATCH v4 net-next 3/4] nfc: s3fwrn5: extract the common phy blocks
Date: Tue, 1 Dec 2020 22:17:35 +0200 [thread overview]
Message-ID: <20201201201735.GC2435@kozik-lap> (raw)
In-Reply-To: <1606830628-10236-4-git-send-email-bongsu.jeon@samsung.com>
On Tue, Dec 01, 2020 at 10:50:27PM +0900, Bongsu Jeon wrote:
> From: Bongsu Jeon <bongsu.jeon@samsung.com>
>
> Extract the common phy blocks to reuse it.
> The UART module will use the common blocks.
>
> Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
> ---
> drivers/nfc/s3fwrn5/Makefile | 2 +-
> drivers/nfc/s3fwrn5/i2c.c | 117 +++++++++++++--------------------------
> drivers/nfc/s3fwrn5/phy_common.c | 63 +++++++++++++++++++++
> drivers/nfc/s3fwrn5/phy_common.h | 36 ++++++++++++
> 4 files changed, 139 insertions(+), 79 deletions(-)
> create mode 100644 drivers/nfc/s3fwrn5/phy_common.c
> create mode 100644 drivers/nfc/s3fwrn5/phy_common.h
>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-12-01 20:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 13:50 [PATCH v4 net-next 0/4] nfc: s3fwrn5: Support a UART interface Bongsu Jeon
2020-12-01 13:50 ` [PATCH v4 net-next 1/4] dt-bindings: net: " Bongsu Jeon
2020-12-01 20:07 ` Krzysztof Kozlowski
2020-12-01 13:50 ` [PATCH v4 net-next 2/4] nfc: s3fwrn5: reduce the EN_WAIT_TIME Bongsu Jeon
2020-12-01 13:50 ` [PATCH v4 net-next 3/4] nfc: s3fwrn5: extract the common phy blocks Bongsu Jeon
2020-12-01 20:17 ` Krzysztof Kozlowski [this message]
2020-12-01 13:50 ` [PATCH v4 net-next 4/4] nfc: s3fwrn5: Support a UART interface Bongsu Jeon
2020-12-01 20:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201201735.GC2435@kozik-lap \
--to=krzk@kernel.org \
--cc=bongsu.jeon2@gmail.com \
--cc=bongsu.jeon@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfc@lists.01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).