From: Kees Cook <keescook@chromium.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Emese Revfy <re.emese@gmail.com>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL 2/2] Kconfig updates for v5.10-rc1
Date: Wed, 2 Dec 2020 10:58:12 -0800 [thread overview]
Message-ID: <202012021057.68B54233E@keescook> (raw)
In-Reply-To: <CAK7LNAS_18S9_OasKOaoEW6os3=bYf4wi7fPewfdHyCS2mLsyA@mail.gmail.com>
On Wed, Dec 02, 2020 at 10:03:47PM +0900, Masahiro Yamada wrote:
> On Wed, Dec 2, 2020 at 9:53 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > Hi Linus,
> >
> > On Sun, Nov 29, 2020 at 3:28 AM Linus Torvalds
> > <torvalds@linux-foundation.org> wrote:
> > >
> > > On Fri, Nov 27, 2020 at 11:05 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
> > > >
> > > > As for the cc1plus cost, I got a similar result.
> > > >
> > > > Running scripts/gcc-plugin.sh directly
> > > > took me 0.5 sec, which is a fourth
> > > > of the allmodconfig run-time.
> > > >
> > > > Actually, I did not know this shell script
> > > > was so expensive to run...
> > >
> > > So it turns out that one reason it's so expensive to run is that it
> > > does a *lot* more than it claims to do.
> > >
> > > It says "we need a c++ compiler that supports the designated
> > > initializer GNU extension", but then it actually includes a header
> > > file from hell, rather than just test designated initializers.
> > >
> > > This patch makes the cc1plus overhead go down a lot. That said, I'm
> > > doubtful we really want gcc plugins at all, considering that the only
> > > real users have all apparently migrated to clang builtin functionality
> > > instead.
> > >
> > > Linus
> >
> >
> > The attached patch looks OK to me.
> >
> > Just a nit:
> > Now that the test code does not include any header,
> > you can also delete
> > "-I $srctree/gcc-plugins -I $gccplugins_dir/include"
> >
> >
> > If you apply it directly, please feel free to add
> >
> > Reviewed-by: Masahiro Yamada <masahiroy@kernel.org>
>
>
> BTW, gcc plugins are always compiled with g++.
>
> Why do we need to compile the following in the first place?
>
> class test {
> public:
> int test;
> } test = {
> .test = 1
> };
>
>
> I think any C++ compiler will succeed
> in compiling such simple code.
>
>
>
> So,
>
> test -e "$gccplugins_dir/include/plugin-version.h"
>
> looks enough to me.
>
>
>
> What is the intention of this compile test?
Yeah, I'd agree: we're just looking for a g++ and plugin-version.h.
--
Kees Cook
next prev parent reply other threads:[~2020-12-02 18:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 13:49 [GIT PULL 2/2] Kconfig updates for v5.10-rc1 Masahiro Yamada
2020-10-22 20:25 ` pr-tracker-bot
2020-11-27 21:08 ` Linus Torvalds
2020-11-27 21:15 ` Linus Torvalds
2020-11-27 21:53 ` Linus Torvalds
2020-11-27 22:05 ` Linus Torvalds
2020-11-28 7:04 ` Masahiro Yamada
2020-11-28 18:28 ` Linus Torvalds
2020-12-02 0:55 ` Kees Cook
2020-12-02 12:53 ` Masahiro Yamada
2020-12-02 13:03 ` Masahiro Yamada
2020-12-02 18:58 ` Kees Cook [this message]
2020-12-02 20:13 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2020-10-22 13:47 Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012021057.68B54233E@keescook \
--to=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=re.emese@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).