From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4295AC83012 for ; Wed, 2 Dec 2020 12:24:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E95F32222C for ; Wed, 2 Dec 2020 12:24:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729941AbgLBMYM (ORCPT ); Wed, 2 Dec 2020 07:24:12 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:50542 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727571AbgLBMYL (ORCPT ); Wed, 2 Dec 2020 07:24:11 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 5BDDE1C0B9E; Wed, 2 Dec 2020 13:23:29 +0100 (CET) Date: Wed, 2 Dec 2020 13:23:29 +0100 From: Pavel Machek To: Gene Chen Cc: jacek.anaszewski@gmail.com, robh+dt@kernel.org, matthias.bgg@gmail.com, dmurphy@ti.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, gene_chen@richtek.com, Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com, benjamin.chao@mediatek.com Subject: Re: [PATCH v11 3/5] dt-bindings: leds: Add LED_FUNCTION_MOONLIGHT definitions Message-ID: <20201202122329.GA30929@duo.ucw.cz> References: <1606906011-25633-1-git-send-email-gene.chen.richtek@gmail.com> <1606906011-25633-4-git-send-email-gene.chen.richtek@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vkogqOf2sHV7VnPd" Content-Disposition: inline In-Reply-To: <1606906011-25633-4-git-send-email-gene.chen.richtek@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vkogqOf2sHV7VnPd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2020-12-02 18:46:49, Gene Chen wrote: > From: Gene Chen >=20 > Add LED_FUNCTION_MOONLIGHT definitions >=20 > Signed-off-by: Gene Chen > Acked-by: Jacek Anaszewski > Acked-by: Rob Herring > --- > include/dt-bindings/leds/common.h | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds= /common.h > index 52b619d..843e65d 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -78,6 +78,7 @@ > #define LED_FUNCTION_INDICATOR "indicator" > #define LED_FUNCTION_LAN "lan" > #define LED_FUNCTION_MAIL "mail" > +#define LED_FUNCTION_MOONLIGHT "moonlight" There's "torch" function that should be used for this. I guess comment should be added with explanation what exactly that is and how should the LED be named. Best regards, Pavel --=20 http://www.livejournal.com/~pavelmachek --vkogqOf2sHV7VnPd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCX8eHQQAKCRAw5/Bqldv6 8pVXAJ4tYF70hprb4/4PCWCbjb4eUQZMggCfTWFQi7Zc8SFGxzn0gUYPceNUWSg= =d03t -----END PGP SIGNATURE----- --vkogqOf2sHV7VnPd--