From: Jason Gunthorpe <jgg@ziepe.ca>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Miroslav Lichvar <mlichvar@redhat.com>,
linux-kernel@vger.kernel.org,
John Stultz <john.stultz@linaro.org>,
Prarit Bhargava <prarit@redhat.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] rtc: adapt allowed RTC update error
Date: Thu, 3 Dec 2020 12:16:22 -0400 [thread overview]
Message-ID: <20201203161622.GA1317829@ziepe.ca> (raw)
In-Reply-To: <87pn3qdhli.fsf@nanos.tec.linutronix.de>
On Thu, Dec 03, 2020 at 04:39:21PM +0100, Thomas Gleixner wrote:
> The logic in sync_cmos_clock() and rtc_set_ntp_time() is different as I
> pointed out: sync_cmos_clock() hands -500ms to rtc_tv_nsec_ok() and
> rtc_set_ntp_time() uses +500ms, IOW exactly ONE second difference in
> behaviour.
I understood this is because the two APIs work differently, rmk
explained this as:
> 1. kernel/time/ntp.c assumes that all RTCs want to be told to set the
> time at around 500ms into the second.
>
> 2. drivers/rtc/systohc.c assumes that if the time being set is >= 500ms,
> then we want to set the _next_ second.
ie one path is supposed to round down and one path is supposed to
round up, so you get to that 1s difference..
IIRC this is also connected to why the offset is signed..
Jason
next prev parent reply other threads:[~2020-12-03 16:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 14:38 [PATCH] rtc: adapt allowed RTC update error Miroslav Lichvar
2020-12-01 16:12 ` Jason Gunthorpe
2020-12-01 17:14 ` Miroslav Lichvar
2020-12-01 17:35 ` Jason Gunthorpe
2020-12-02 10:01 ` [PATCHv2] " Miroslav Lichvar
2020-12-02 13:44 ` [PATCH] " Thomas Gleixner
2020-12-02 15:07 ` Miroslav Lichvar
2020-12-02 15:36 ` Miroslav Lichvar
2020-12-02 18:36 ` Thomas Gleixner
2020-12-02 16:27 ` Jason Gunthorpe
2020-12-02 19:21 ` Thomas Gleixner
2020-12-02 20:54 ` Jason Gunthorpe
2020-12-02 22:08 ` Thomas Gleixner
2020-12-02 23:03 ` Jason Gunthorpe
2020-12-03 1:14 ` Thomas Gleixner
2020-12-03 2:04 ` Jason Gunthorpe
2020-12-03 2:10 ` Alexandre Belloni
2020-12-03 15:39 ` Thomas Gleixner
2020-12-03 16:16 ` Jason Gunthorpe [this message]
2020-12-03 21:05 ` Thomas Gleixner
2020-12-03 21:31 ` Thomas Gleixner
2020-12-03 22:36 ` Jason Gunthorpe
2020-12-04 13:02 ` Thomas Gleixner
2020-12-04 14:08 ` Jason Gunthorpe
2020-12-04 14:37 ` Alexandre Belloni
2020-12-04 14:46 ` Jason Gunthorpe
2020-12-04 15:08 ` Alexandre Belloni
2020-12-04 15:57 ` Jason Gunthorpe
2020-12-04 16:35 ` Alexandre Belloni
2020-12-03 22:00 ` Alexandre Belloni
2020-12-04 9:34 ` Thomas Gleixner
2020-12-04 9:51 ` Alexandre Belloni
2020-12-04 10:44 ` Thomas Gleixner
2020-12-03 17:29 ` Alexandre Belloni
2020-12-03 19:52 ` Thomas Gleixner
2020-12-03 15:52 ` Jason Gunthorpe
2020-12-03 16:07 ` Alexandre Belloni
2020-12-03 20:10 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203161622.GA1317829@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mlichvar@redhat.com \
--cc=peterz@infradead.org \
--cc=prarit@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).