From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
Cc: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>,
Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Updated locking documentation for transaction_t
Date: Thu, 3 Dec 2020 15:39:15 -0500 [thread overview]
Message-ID: <20201203203915.GN441757@mit.edu> (raw)
In-Reply-To: <29d6de5d-4abc-e836-7b14-bb67d782a752@tu-dortmund.de>
On Thu, Dec 03, 2020 at 03:38:40PM +0100, Alexander Lochmann wrote:
>
>
> On 03.12.20 15:04, Theodore Y. Ts'o wrote:
> > On Thu, Oct 15, 2020 at 03:26:28PM +0200, Alexander Lochmann wrote:
> > > Hi folks,
> > >
> > > I've updated the lock documentation according to our finding for
> > > transaction_t.
> > > Does this patch look good to you?
> >
> > I updated the annotations to match with the local usage, e.g:
> >
> > * When commit was requested [journal_t.j_state_lock]
> >
> > became:
> >
> > * When commit was requested [j_state_lock]What do you mean by local usage?
> The annotations of other members of transaction_t?
Yes, I'd like the annotations of the other objects to be consistent,
and just use j_state_lock, j_list_lock, etc., for the other annotations.
> Shouldn't the annotation look like this?
> [t_journal->j_state_lock]
> It would be more precise.
It's more precise, but it's also unnecessary in this case, since all
of the elements of the journal have a j_ prefix, elements of a
transaction_t have a t_ prefix, etc. There is also no other structure
element which has a j_state_lock name *other* than in journal_t.
Cheers,
- Ted
next prev parent reply other threads:[~2020-12-03 20:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 8:35 [PATCH v3] Updated locking documentation for transaction_t Alexander Lochmann
2019-06-20 20:45 ` Alexander Lochmann
2020-10-15 13:26 ` Alexander Lochmann
2020-12-03 14:04 ` Theodore Y. Ts'o
2020-12-03 14:38 ` Alexander Lochmann
2020-12-03 20:39 ` Theodore Y. Ts'o [this message]
2021-02-11 17:14 Alexander Lochmann
2021-03-17 20:58 ` Alexander Lochmann
2021-04-02 15:40 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203203915.GN441757@mit.edu \
--to=tytso@mit.edu \
--cc=alexander.lochmann@tu-dortmund.de \
--cc=horst.schirmeier@tu-dortmund.de \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).