From: Wang Hai <wanghai38@huawei.com>
To: <johan@kernel.org>, <elder@kernel.org>,
<gregkh@linuxfoundation.org>, <dan.carpenter@oracle.com>,
<aibhav.sr@gmail.com>
Cc: <greybus-dev@lists.linaro.org>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] staging: greybus: audio: Add missing unlock in gbaudio_dapm_free_controls()
Date: Fri, 4 Dec 2020 10:13:50 +0800 [thread overview]
Message-ID: <20201204021350.28182-1-wanghai38@huawei.com> (raw)
Add the missing unlock before return from function
gbaudio_dapm_free_controls() in the error handling case.
Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic audio module")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
drivers/staging/greybus/audio_helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/greybus/audio_helper.c b/drivers/staging/greybus/audio_helper.c
index 237531ba60f3..293675dbea10 100644
--- a/drivers/staging/greybus/audio_helper.c
+++ b/drivers/staging/greybus/audio_helper.c
@@ -135,6 +135,7 @@ int gbaudio_dapm_free_controls(struct snd_soc_dapm_context *dapm,
if (!w) {
dev_err(dapm->dev, "%s: widget not found\n",
widget->name);
+ mutex_unlock(&dapm->card->dapm_mutex);
return -EINVAL;
}
widget++;
--
2.17.1
next reply other threads:[~2020-12-04 2:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 2:13 Wang Hai [this message]
2020-12-04 8:40 ` [PATCH] staging: greybus: audio: Add missing unlock in gbaudio_dapm_free_controls() Johan Hovold
2020-12-04 9:19 ` wanghai (M)
2020-12-04 10:40 ` Johan Hovold
2020-12-04 18:02 ` Vaibhav Agarwal
2020-12-05 10:44 ` wanghai (M)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204021350.28182-1-wanghai38@huawei.com \
--to=wanghai38@huawei.com \
--cc=aibhav.sr@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).