From: Gao Xiang <hsiangkao@redhat.com>
To: Chao Yu <yuchao0@huawei.com>
Cc: Eric Biggers <ebiggers@kernel.org>,
jaegeuk@kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v6] f2fs: compress: support compress level
Date: Fri, 4 Dec 2020 15:43:23 +0800 [thread overview]
Message-ID: <20201204074323.GA2025226@xiangao.remote.csb> (raw)
In-Reply-To: <d713f69b-af1b-4e4a-41ad-267a3b9026ac@huawei.com>
Hi Chao,
On Fri, Dec 04, 2020 at 03:09:20PM +0800, Chao Yu wrote:
> On 2020/12/4 8:31, Gao Xiang wrote:
> > could make more sense), could you leave some CR numbers about these
> > algorithms on typical datasets (enwik9, silisia.tar or else.) with 16k
> > cluster size?
>
> Just from a quick test with enwik9 on vm:
>
> Original blocks: 244382
>
> lz4 lz4hc-9
> compressed blocks 170647 163270
> compress ratio 69.8% 66.8%
> speed 16.4207 s, 60.9 MB/s 26.7299 s, 37.4 MB/s
>
> compress ratio = after / before
Thanks for the confirmation. it'd be better to add this to commit message
if needed when adding a new algorithm to show the benefits.
About the speed, I think which is also limited to storage device and other
conditions (I mean the CPU loading during the writeback might be different
between lz4 and lz4hc-9 due to many other bounds, e.g. UFS 3.0 seq
write is somewhat higher vs VM. lz4 may have higher bandwidth on high
level devices since it seems some IO bound here... I guess but not sure,
since pure in-memory lz4 is fast according to lzbench / lz4 homepage.)
Anyway, it's up to f2fs folks if it's useful :) (the CR number is what
I expect though... I'm a bit of afraid the CPU runtime loading.)
Thanks for your time!
Thanks,
Gao Xiang
>
> Thanks,
>
next prev parent reply other threads:[~2020-12-04 7:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 6:17 [PATCH v6] f2fs: compress: support compress level Chao Yu
2020-12-03 19:32 ` [f2fs-dev] " Eric Biggers
2020-12-04 0:31 ` Gao Xiang
2020-12-04 1:56 ` Chao Yu
2020-12-04 2:06 ` Gao Xiang
2020-12-04 2:38 ` Chao Yu
2020-12-04 2:47 ` Gao Xiang
2020-12-04 3:11 ` Chao Yu
2020-12-04 3:21 ` Gao Xiang
2020-12-04 7:09 ` Chao Yu
2020-12-04 7:43 ` Gao Xiang [this message]
2020-12-04 8:50 ` Chao Yu
2020-12-04 9:10 ` Gao Xiang
2020-12-04 1:18 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204074323.GA2025226@xiangao.remote.csb \
--to=hsiangkao@redhat.com \
--cc=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).