From: Marc Zyngier <maz@kernel.org>
To: linux-usb@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-team@android.com
Subject: [PATCH 4/4] USB: serial: ftdi_sio: Drop GPIO line checking dead code
Date: Fri, 4 Dec 2020 16:47:39 +0000 [thread overview]
Message-ID: <20201204164739.781812-5-maz@kernel.org> (raw)
In-Reply-To: <20201204164739.781812-1-maz@kernel.org>
Now that the code code can track the validity of GPIO pins,
there is no need to check whether the line is valid.
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
drivers/usb/serial/ftdi_sio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index b9d3b33891fc..2c8a0b9aac92 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -1841,9 +1841,6 @@ static int ftdi_gpio_request(struct gpio_chip *gc, unsigned int offset)
struct ftdi_private *priv = usb_get_serial_port_data(port);
int result;
- if (priv->gpio_altfunc & BIT(offset))
- return -ENODEV;
-
mutex_lock(&priv->gpio_lock);
if (!priv->gpio_used) {
/* Set default pin states, as we cannot get them from device */
--
2.28.0
next prev parent reply other threads:[~2020-12-04 16:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 16:47 [PATCH 0/4] USB: ftdio_sio: GPIO validity fixes Marc Zyngier
2020-12-04 16:47 ` [PATCH 1/4] gpiolib: cdev: Flag invalid GPIOs as used Marc Zyngier
2020-12-07 14:16 ` Johan Hovold
2020-12-07 14:59 ` Marc Zyngier
2020-12-09 9:25 ` Linus Walleij
2020-12-04 16:47 ` [PATCH 2/4] USB: serial: ftdi_sio: Report the valid GPIO lines to gpiolib Marc Zyngier
2020-12-09 9:28 ` Linus Walleij
2020-12-04 16:47 ` [PATCH 3/4] USB: serial: ftdi_sio: Log the CBUS GPIO validity Marc Zyngier
2020-12-07 14:29 ` Johan Hovold
2020-12-07 15:00 ` Marc Zyngier
2020-12-07 15:19 ` Johan Hovold
2020-12-09 9:35 ` Linus Walleij
2020-12-09 17:05 ` Johan Hovold
2020-12-09 17:39 ` Johan Hovold
2020-12-04 16:47 ` Marc Zyngier [this message]
2020-12-07 9:55 ` [PATCH 0/4] USB: ftdio_sio: GPIO validity fixes Andy Shevchenko
2020-12-07 14:01 ` Johan Hovold
2020-12-07 14:41 ` Marc Zyngier
2020-12-07 15:08 ` Johan Hovold
2020-12-07 15:34 ` Marc Zyngier
2020-12-07 15:49 ` Johan Hovold
2020-12-09 9:20 ` Linus Walleij
2020-12-09 15:42 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204164739.781812-5-maz@kernel.org \
--to=maz@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kernel-team@android.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).