From: laniel_francis@privacyrequired.com
To: Bin Liu <b-liu@ti.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Francis Laniel <laniel_francis@privacyrequired.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH v1 11/12] musb: Replace strstarts() by str_has_prefix().
Date: Fri, 4 Dec 2020 18:03:17 +0100 [thread overview]
Message-ID: <20201204170319.20383-12-laniel_francis@privacyrequired.com> (raw)
In-Reply-To: <20201204170319.20383-1-laniel_francis@privacyrequired.com>
From: Francis Laniel <laniel_francis@privacyrequired.com>
The two functions indicates if a string begins with a given prefix.
The only difference is that strstarts() returns a bool while str_has_prefix()
returns the length of the prefix if the string begins with it or 0 otherwise.
Signed-off-by: Francis Laniel <laniel_francis@privacyrequired.com>
---
drivers/usb/musb/musb_cppi41.c | 4 ++--
drivers/usb/musb/musb_debugfs.c | 20 ++++++++++----------
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers/usb/musb/musb_cppi41.c
index 7fbb8a307145..a6d22c0957c5 100644
--- a/drivers/usb/musb/musb_cppi41.c
+++ b/drivers/usb/musb/musb_cppi41.c
@@ -686,9 +686,9 @@ static int cppi41_dma_controller_start(struct cppi41_dma_controller *controller)
ret = of_property_read_string_index(np, "dma-names", i, &str);
if (ret)
goto err;
- if (strstarts(str, "tx"))
+ if (str_has_prefix(str, "tx"))
is_tx = 1;
- else if (strstarts(str, "rx"))
+ else if (str_has_prefix(str, "rx"))
is_tx = 0;
else {
dev_err(dev, "Wrong dmatype %s\n", str);
diff --git a/drivers/usb/musb/musb_debugfs.c b/drivers/usb/musb/musb_debugfs.c
index 30a89aa8a3e7..47fc32bc6507 100644
--- a/drivers/usb/musb/musb_debugfs.c
+++ b/drivers/usb/musb/musb_debugfs.c
@@ -181,36 +181,36 @@ static ssize_t musb_test_mode_write(struct file *file,
goto ret;
}
- if (strstarts(buf, "force host full-speed"))
+ if (str_has_prefix(buf, "force host full-speed"))
test = MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_FS;
- else if (strstarts(buf, "force host high-speed"))
+ else if (str_has_prefix(buf, "force host high-speed"))
test = MUSB_TEST_FORCE_HOST | MUSB_TEST_FORCE_HS;
- else if (strstarts(buf, "force host"))
+ else if (str_has_prefix(buf, "force host"))
test = MUSB_TEST_FORCE_HOST;
- else if (strstarts(buf, "fifo access"))
+ else if (str_has_prefix(buf, "fifo access"))
test = MUSB_TEST_FIFO_ACCESS;
- else if (strstarts(buf, "force full-speed"))
+ else if (str_has_prefix(buf, "force full-speed"))
test = MUSB_TEST_FORCE_FS;
- else if (strstarts(buf, "force high-speed"))
+ else if (str_has_prefix(buf, "force high-speed"))
test = MUSB_TEST_FORCE_HS;
- else if (strstarts(buf, "test packet")) {
+ else if (str_has_prefix(buf, "test packet")) {
test = MUSB_TEST_PACKET;
musb_load_testpacket(musb);
}
- else if (strstarts(buf, "test K"))
+ else if (str_has_prefix(buf, "test K"))
test = MUSB_TEST_K;
- else if (strstarts(buf, "test J"))
+ else if (str_has_prefix(buf, "test J"))
test = MUSB_TEST_J;
- else if (strstarts(buf, "test SE0 NAK"))
+ else if (str_has_prefix(buf, "test SE0 NAK"))
test = MUSB_TEST_SE0_NAK;
musb_writeb(musb->mregs, MUSB_TESTMODE, test);
--
2.20.1
next prev parent reply other threads:[~2020-12-04 17:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 17:03 [RFC PATCH v1 00/12] Replace strstarts() by str_has_prefix() laniel_francis
2020-12-04 17:03 ` [RFC PATCH v1 01/12] arm: " laniel_francis
2020-12-04 17:03 ` [RFC PATCH v1 02/12] mips: " laniel_francis
2020-12-04 17:03 ` [RFC PATCH v1 03/12] crypto: " laniel_francis
2020-12-04 17:03 ` [RFC PATCH v1 04/12] device-mapper: " laniel_francis
2020-12-04 17:03 ` [RFC PATCH v1 05/12] renesas: " laniel_francis
2020-12-04 17:03 ` [RFC PATCH v1 06/12] omap: " laniel_francis
2020-12-04 17:03 ` [RFC PATCH v1 07/12] efi: " laniel_francis
2020-12-04 17:07 ` Ard Biesheuvel
2020-12-04 17:19 ` Francis Laniel
2020-12-04 18:02 ` James Bottomley
2020-12-05 19:08 ` Francis Laniel
2020-12-05 19:36 ` Ard Biesheuvel
2020-12-05 20:24 ` James Bottomley
2020-12-05 20:57 ` Ard Biesheuvel
2020-12-05 21:15 ` James Bottomley
2020-12-05 21:20 ` Ard Biesheuvel
2020-12-05 23:04 ` James Bottomley
2020-12-07 15:10 ` Steven Rostedt
2020-12-07 16:25 ` David Laight
2020-12-05 20:28 ` Rasmus Villemoes
2020-12-10 18:14 ` Arvind Sankar
2020-12-11 9:45 ` David Laight
2020-12-11 16:10 ` Arvind Sankar
2020-12-04 17:03 ` [RFC PATCH v1 08/12] ide: " laniel_francis
2020-12-04 17:03 ` [RFC PATCH v1 09/12] mips: " laniel_francis
2020-12-04 17:03 ` [RFC PATCH v1 10/12] module: " laniel_francis
2020-12-04 17:03 ` laniel_francis [this message]
2020-12-04 17:03 ` [RFC PATCH v1 12/12] string.h: Remove strstarts() laniel_francis
2020-12-04 17:56 ` [RFC PATCH v1 00/12] Replace strstarts() by str_has_prefix() James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201204170319.20383-12-laniel_francis@privacyrequired.com \
--to=laniel_francis@privacyrequired.com \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).