From: Andrew Morton <akpm@linux-foundation.org>
To: Chris Down <chris@chrisdown.name>
Cc: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>,
"qiang.zhang@windriver.com" <qiang.zhang@windriver.com>,
"sfr@canb.auug.org.au" <sfr@canb.auug.org.au>,
"aryabinin@virtuozzo.com" <aryabinin@virtuozzo.com>,
"dvyukov@google.com" <dvyukov@google.com>,
"andreyknvl@google.com" <andreyknvl@google.com>,
"qcai@redhat.com" <qcai@redhat.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
walter-zh.wu@mediatek.com
Subject: Re: [PATCH] kasan: fix slab double free when cpu-hotplug
Date: Fri, 11 Dec 2020 11:39:09 -0800 [thread overview]
Message-ID: <20201211113909.230e68fcb66193aa71661ddd@linux-foundation.org> (raw)
In-Reply-To: <X9N3i+EwydXFc4HW@chrisdown.name>
On Fri, 11 Dec 2020 13:43:39 +0000 Chris Down <chris@chrisdown.name> wrote:
> Hi folks,
>
> Andrew Morton writes:
> >@@ -188,6 +190,10 @@ void quarantine_put(struct kasan_free_me
> > local_irq_save(flags);
> >
> > q = this_cpu_ptr(&cpu_quarantine);
> >+ if (q->offline) {
> >+ local_irq_restore(flags);
> >+ return;
> >+ }
> > qlist_put(q, &info->quarantine_link, cache->size);
> > if (unlikely(q->bytes > QUARANTINE_PERCPU_SIZE)) {
> > qlist_move_all(q, &temp);
>
> I'm afraid as well as the issues already identified, this also fails, because
> `quarantine_put` now returns a bool after "kasan: sanitize objects when
> metadata doesn't fit":
>
> mm/kasan/quarantine.c: In function ‘quarantine_put’:
> mm/kasan/quarantine.c:198:3: error: ‘return’ with no value, in function returning non-void [-Werror=return-type]
> 198 | return;
> | ^~~~~~
> mm/kasan/quarantine.c:171:6: note: declared here
> 171 | bool quarantine_put(struct kmem_cache *cache, void *object)
Yup, thanks. I think I have this all fixed now, using the old
apply-one-patch-compile-everything-repeat approach.
prev parent reply other threads:[~2020-12-11 21:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 10:22 [PATCH] kasan: fix slab double free when cpu-hotplug qiang.zhang
2020-12-04 12:01 ` Kuan-Ying Lee
2020-12-05 1:25 ` Andrew Morton
2020-12-05 16:17 ` Kuan-Ying Lee
2020-12-06 1:09 ` Andrew Morton
2020-12-07 2:06 ` Kuan-Ying Lee
2020-12-07 7:00 ` Kuan-Ying Lee
2020-12-11 13:43 ` Chris Down
2020-12-11 19:39 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211113909.230e68fcb66193aa71661ddd@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Kuan-Ying.Lee@mediatek.com \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=chris@chrisdown.name \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=qcai@redhat.com \
--cc=qiang.zhang@windriver.com \
--cc=sfr@canb.auug.org.au \
--cc=walter-zh.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).