linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
	maple-tree@lists.infradead.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, Andrew Morton <akpm@google.com>,
	Linux Memory Management List <linux-mm@kvack.org>,
	Song Liu <songliubraving@fb.com>,
	Davidlohr Bueso <dave@stgolabs.net>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	Matthew Wilcox <willy@infradead.org>,
	Jerome Glisse <jglisse@redhat.com>
Subject: Re: [PATCH 06/28] mm: Start tracking VMAs with maple tree
Date: Sat, 12 Dec 2020 03:30:15 +0800	[thread overview]
Message-ID: <202012120304.z7expfJf-lkp@intel.com> (raw)
In-Reply-To: <20201210170402.3468568-7-Liam.Howlett@Oracle.com>

[-- Attachment #1: Type: text/plain, Size: 10684 bytes --]

Hi "Liam,

I love your patch! Yet something to improve:

[auto build test ERROR on efi/next]
[also build test ERROR on linus/master v5.10-rc7]
[cannot apply to tip/x86/core hnaz-linux-mm/master next-20201211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Liam-R-Howlett/RFC-mm-Introducing-the-Maple-Tree/20201211-011029
base:   https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git next
config: i386-randconfig-s001-20201210 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-179-ga00755aa-dirty
        # https://github.com/0day-ci/linux/commit/991a17ff32a6bc9549655cd0aea43c386fdea1c6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Liam-R-Howlett/RFC-mm-Introducing-the-Maple-Tree/20201211-011029
        git checkout 991a17ff32a6bc9549655cd0aea43c386fdea1c6
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/mm_types.h:11,
                    from include/linux/mmzone.h:21,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:20,
                    from arch/x86/kernel/asm-offsets.c:9:
>> include/linux/maple_tree.h:79:22: error: 'MAPLE_RANGE64_SLOTS' undeclared here (not in a function)
      79 |  unsigned long pivot[MAPLE_RANGE64_SLOTS - 1];
         |                      ^~~~~~~~~~~~~~~~~~~
>> include/linux/maple_tree.h:85:22: error: 'MAPLE_ARANGE64_SLOTS' undeclared here (not in a function)
      85 |  unsigned long pivot[MAPLE_ARANGE64_SLOTS - 1];
         |                      ^~~~~~~~~~~~~~~~~~~~
>> include/linux/maple_tree.h:91:28: error: 'MAPLE_NODE_SLOTS' undeclared here (not in a function); did you mean 'MAPLE_ALLOC_SLOTS'?
      91 | #define MAPLE_ALLOC_SLOTS (MAPLE_NODE_SLOTS - 1)
         |                            ^~~~~~~~~~~~~~~~
   include/linux/maple_tree.h:96:27: note: in expansion of macro 'MAPLE_ALLOC_SLOTS'
      96 |  struct maple_alloc *slot[MAPLE_ALLOC_SLOTS];
         |                           ^~~~~~~~~~~~~~~~~
--
   In file included from include/linux/mm_types.h:11,
                    from include/linux/mmzone.h:21,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:20,
                    from arch/x86/kernel/asm-offsets.c:9:
>> include/linux/maple_tree.h:79:22: error: 'MAPLE_RANGE64_SLOTS' undeclared here (not in a function)
      79 |  unsigned long pivot[MAPLE_RANGE64_SLOTS - 1];
         |                      ^~~~~~~~~~~~~~~~~~~
>> include/linux/maple_tree.h:85:22: error: 'MAPLE_ARANGE64_SLOTS' undeclared here (not in a function)
      85 |  unsigned long pivot[MAPLE_ARANGE64_SLOTS - 1];
         |                      ^~~~~~~~~~~~~~~~~~~~
>> include/linux/maple_tree.h:91:28: error: 'MAPLE_NODE_SLOTS' undeclared here (not in a function); did you mean 'MAPLE_ALLOC_SLOTS'?
      91 | #define MAPLE_ALLOC_SLOTS (MAPLE_NODE_SLOTS - 1)
         |                            ^~~~~~~~~~~~~~~~
   include/linux/maple_tree.h:96:27: note: in expansion of macro 'MAPLE_ALLOC_SLOTS'
      96 |  struct maple_alloc *slot[MAPLE_ALLOC_SLOTS];
         |                           ^~~~~~~~~~~~~~~~~
   make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1200: prepare0] Error 2
   make[1]: Target 'modules_prepare' not remade because of errors.
   make: *** [Makefile:185: __sub-make] Error 2
   make: Target 'modules_prepare' not remade because of errors.
--
   In file included from include/linux/mm_types.h:11,
                    from include/linux/mmzone.h:21,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from include/linux/crypto.h:20,
                    from arch/x86/kernel/asm-offsets.c:9:
>> include/linux/maple_tree.h:79:22: error: 'MAPLE_RANGE64_SLOTS' undeclared here (not in a function)
      79 |  unsigned long pivot[MAPLE_RANGE64_SLOTS - 1];
         |                      ^~~~~~~~~~~~~~~~~~~
>> include/linux/maple_tree.h:85:22: error: 'MAPLE_ARANGE64_SLOTS' undeclared here (not in a function)
      85 |  unsigned long pivot[MAPLE_ARANGE64_SLOTS - 1];
         |                      ^~~~~~~~~~~~~~~~~~~~
>> include/linux/maple_tree.h:91:28: error: 'MAPLE_NODE_SLOTS' undeclared here (not in a function); did you mean 'MAPLE_ALLOC_SLOTS'?
      91 | #define MAPLE_ALLOC_SLOTS (MAPLE_NODE_SLOTS - 1)
         |                            ^~~~~~~~~~~~~~~~
   include/linux/maple_tree.h:96:27: note: in expansion of macro 'MAPLE_ALLOC_SLOTS'
      96 |  struct maple_alloc *slot[MAPLE_ALLOC_SLOTS];
         |                           ^~~~~~~~~~~~~~~~~
   make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1200: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:185: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

vim +/MAPLE_RANGE64_SLOTS +79 include/linux/maple_tree.h

d79b3ea66666bc9 Liam R. Howlett 2020-12-10  40  
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  41  
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  42  /**
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  43   * maple_tree node explained
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  44   *
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  45   * Each node type has a number of slots for entries and a number of slots for
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  46   * pivots.  In the case of dense nodes, the pivots are implied by the position
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  47   * and are simply the slot index + the minimum of the node.
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  48   *
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  49   * In regular B-Tree terms, pivots are called keys.  The term pivot is used to
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  50   * indicate that the tree is specifying ranges,  Pivots may appear in the
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  51   * subtree with an entry attached to the value where as keys are unique to a
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  52   * specific position of a B-tree.  Pivot values are inclusive of the slot with
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  53   * the same index.
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  54   *
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  55   *
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  56   * The following illustrates the layout of a range64 nodes slots and pivots.
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  57   *
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  58   *           _________________________________
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  59   *  Slots -> | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 |
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  60   *           ┬   ┬   ┬   ┬   ┬   ┬   ┬   ┬   ┬
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  61   *           │   │   │   │   │   │   │   │   └─ Implied maximum
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  62   *           │   │   │   │   │   │   │   └─ Pivot 6
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  63   *           │   │   │   │   │   │   └─ Pivot 5
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  64   *           │   │   │   │   │   └─ Pivot 4
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  65   *           │   │   │   │   └─ Pivot 3
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  66   *           │   │   │   └─ Pivot 2
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  67   *           │   │   └─ Pivot 1
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  68   *           │   └─ Pivot 0
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  69   *           └─  Implied minimum
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  70   *
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  71   * Slot contents:
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  72   *  Internal (non-leaf) nodes contain pointers to other nodes.
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  73   *  Leaf nodes contain entries.
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  74   *
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  75   *
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  76   */
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  77  struct maple_range_64 {
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  78  	struct maple_pnode *parent;
d79b3ea66666bc9 Liam R. Howlett 2020-12-10 @79  	unsigned long pivot[MAPLE_RANGE64_SLOTS - 1];
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  80  	void __rcu *slot[MAPLE_RANGE64_SLOTS];
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  81  };
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  82  
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  83  struct maple_arange_64 {
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  84  	struct maple_pnode *parent;
d79b3ea66666bc9 Liam R. Howlett 2020-12-10 @85  	unsigned long pivot[MAPLE_ARANGE64_SLOTS - 1];
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  86  	void __rcu *slot[MAPLE_ARANGE64_SLOTS];
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  87  	unsigned long gap[MAPLE_ARANGE64_SLOTS];
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  88  	unsigned char meta;
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  89  };
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  90  
d79b3ea66666bc9 Liam R. Howlett 2020-12-10 @91  #define MAPLE_ALLOC_SLOTS (MAPLE_NODE_SLOTS - 1)
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  92  struct maple_alloc {
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  93  	unsigned long total;
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  94  	unsigned char node_count;
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  95  	unsigned int request_count;
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  96  	struct maple_alloc *slot[MAPLE_ALLOC_SLOTS];
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  97  };
d79b3ea66666bc9 Liam R. Howlett 2020-12-10  98  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31899 bytes --]

  reply	other threads:[~2020-12-11 21:05 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 17:03 [PATCH 00/28] RFC mm: Introducing the Maple Tree Liam R. Howlett
2020-12-10 17:03 ` [PATCH 01/28] radix tree test suite: Enhancements for " Liam R. Howlett
2020-12-10 17:03 ` [PATCH 02/28] radix tree test suite: Add support for fallthrough attribute Liam R. Howlett
2020-12-10 17:03 ` [PATCH 03/28] radix tree test suite: Add support for kmem_cache_free_bulk Liam R. Howlett
2020-12-10 17:03 ` [PATCH 04/28] radix tree test suite: Add keme_cache_alloc_bulk() support Liam R. Howlett
2020-12-10 17:03 ` [PATCH 05/28] Maple Tree: Add new data structure Liam R. Howlett
2020-12-10 17:03 ` [PATCH 06/28] mm: Start tracking VMAs with maple tree Liam R. Howlett
2020-12-11 19:30   ` kernel test robot [this message]
2020-12-10 17:03 ` [PATCH 07/28] mm/mmap: Introduce unlock_range() for code cleanup Liam R. Howlett
2020-12-10 17:03 ` [PATCH 08/28] mm/mmap: Change find_vma() to use the maple tree Liam R. Howlett
2020-12-10 17:03 ` [PATCH 09/28] mm/mmap: Change find_vma_prev() to use " Liam R. Howlett
2020-12-10 17:03 ` [PATCH 10/28] mm/mmap: Change unmapped_area and unmapped_area_topdown " Liam R. Howlett
2020-12-10 17:03 ` [PATCH 11/28] kernel/fork: Convert dup_mmap " Liam R. Howlett
2020-12-10 17:03 ` [PATCH 12/28] mm: Remove rb tree Liam R. Howlett
2020-12-10 17:03 ` [PATCH 13/28] mm/gup: Expose mm_populate_vma() for use when the vma is known Liam R. Howlett
2020-12-10 21:03   ` kernel test robot
2020-12-10 17:03 ` [PATCH 14/28] mm/mmap: Change do_brk_flags() to expand existing VMA and add do_brk_munmap() Liam R. Howlett
2020-12-10 17:03 ` [PATCH 15/28] mm/mmap: Change vm_brk_flags() to use mm_populate_vma() Liam R. Howlett
2020-12-10 17:03 ` [PATCH 16/28] mm: Move find_vma_intersection to mmap.c and change implementation to maple tree Liam R. Howlett
2020-12-10 17:03 ` [PATCH 17/28] mm/mmap: Change mmap_region to use maple tree state Liam R. Howlett
2020-12-10 17:03 ` [PATCH 18/28] mm/mmap: Drop munmap_vma_range() Liam R. Howlett
2020-12-10 17:03 ` [PATCH 19/28] mm: Remove vmacache Liam R. Howlett
2020-12-10 17:03 ` [PATCH 20/28] mm/mmap: Change __do_munmap() to avoid unnecessary lookups Liam R. Howlett
2020-12-10 17:03 ` [PATCH 21/28] mm/mmap: Change __do_munmap() to use a ma_state Liam R. Howlett
2020-12-10 17:03 ` [PATCH 22/28] mm/mmap: Move mmap_region() below do_munmap() Liam R. Howlett
2020-12-10 17:03 ` [PATCH 23/28] mm/mmap: Add do_mas_munmap() and wraper for __do_munmap() Liam R. Howlett
2020-12-10 17:03 ` [PATCH 24/28] mmap: Use find_vma_intersection in do_mmap() for overlap Liam R. Howlett
2020-12-10 17:03 ` [PATCH 25/28] mmap: Remove __do_munmap() in favour of do_mas_munmap() Liam R. Howlett
2020-12-10 17:04 ` [PATCH 26/28] mm/mmap: Change do_brk_munmap() to use do_mas_align_munmap() Liam R. Howlett
2020-12-10 17:04 ` [PATCH 27/28] mmap: Update count_vma_pages_range() to only use one ma_state Liam R. Howlett
2020-12-10 17:04 ` [PATCH 28/28] mmap: make remove_vma_list() inline Liam R. Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202012120304.z7expfJf-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=Liam.Howlett@Oracle.com \
    --cc=akpm@google.com \
    --cc=dave@stgolabs.net \
    --cc=jglisse@redhat.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=paulmck@kernel.org \
    --cc=songliubraving@fb.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).