From: Lee Jones <lee.jones@linaro.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Zheng Yongjun <zhengyongjun3@huawei.com>,
jingoohan1@gmail.com, b.zolnierkie@samsung.com,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon
Date: Tue, 15 Dec 2020 08:04:44 +0000 [thread overview]
Message-ID: <20201215080444.GK5029@dell> (raw)
In-Reply-To: <20201214143632.oiqmvpkai7kurc2d@holly.lan>
On Mon, 14 Dec 2020, Daniel Thompson wrote:
> On Mon, Dec 14, 2020 at 09:34:58PM +0800, Zheng Yongjun wrote:
> > Replace a comma between expression statements by a semicolon.
> >
> > Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
>
> Weird! I guess it was harmless but still seriously weird ;-)
One of these was found in MFD a couple of weeks ago.
Yours was exactly my train of thought!
One suggestion was to convert all semi-colons to commas and do away
with all the curly braces encapsulating if()s, for()s and while()s.
Who knew that was even possible?
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
>
> Thanks!
>
>
> > ---
> > drivers/video/backlight/sky81452-backlight.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/video/backlight/sky81452-backlight.c b/drivers/video/backlight/sky81452-backlight.c
> > index 8268ac43d54f..c95e0de7f4e7 100644
> > --- a/drivers/video/backlight/sky81452-backlight.c
> > +++ b/drivers/video/backlight/sky81452-backlight.c
> > @@ -291,7 +291,7 @@ static int sky81452_bl_probe(struct platform_device *pdev)
> > }
> >
> > memset(&props, 0, sizeof(props));
> > - props.max_brightness = SKY81452_MAX_BRIGHTNESS,
> > + props.max_brightness = SKY81452_MAX_BRIGHTNESS;
> > name = pdata->name ? pdata->name : SKY81452_DEFAULT_NAME;
> > bd = devm_backlight_device_register(dev, name, dev, regmap,
> > &sky81452_bl_ops, &props);
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-12-15 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 13:34 [PATCH -next] backlight: sky81452-backlight: convert comma to semicolon Zheng Yongjun
2020-12-14 14:36 ` Daniel Thompson
2020-12-15 8:04 ` Lee Jones [this message]
2020-12-16 14:36 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215080444.GK5029@dell \
--to=lee.jones@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).