linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: "Vincent Stehlé" <vincent.stehle@laposte.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Julian Wiedmann" <jwi@linux.ibm.com>,
	"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2] net: korina: fix return value
Date: Wed, 16 Dec 2020 15:02:15 -0800	[thread overview]
Message-ID: <20201216150215.6b7f724d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <7e175246-5357-ccf6-6c7e-5f68089f30bf@gmail.com>

On Wed, 16 Dec 2020 13:32:26 -0800 Florian Fainelli wrote:
> On 12/16/20 12:43 PM, Jakub Kicinski wrote:
> > On Mon, 14 Dec 2020 23:09:52 +0100 Vincent Stehlé wrote:  
> >> The ndo_start_xmit() method must not attempt to free the skb to transmit
> >> when returning NETDEV_TX_BUSY. Therefore, make sure the
> >> korina_send_packet() function returns NETDEV_TX_OK when it frees a packet.
> >>
> >> Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC")
> >> Suggested-by: Jakub Kicinski <kuba@kernel.org>
> >> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> >> Cc: David S. Miller <davem@davemloft.net>
> >> Cc: Florian Fainelli <florian.fainelli@telecomint.eu>  
> > 
> > Let me CC Florian's more recent email just in case he wants to review.  
> 
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>

😬

Applied, thanks!

  reply	other threads:[~2020-12-16 23:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-13 17:20 [PATCH] net: korina: remove busy skb free Vincent Stehlé
2020-12-14 10:03 ` Julian Wiedmann
2020-12-14 21:08   ` Jakub Kicinski
2020-12-14 21:27     ` Vincent Stehlé
2020-12-14 22:09     ` [PATCH v2] net: korina: fix return value Vincent Stehlé
2020-12-16 20:43       ` Jakub Kicinski
2020-12-16 21:32         ` Florian Fainelli
2020-12-16 23:02           ` Jakub Kicinski [this message]
2020-12-14 21:14   ` [PATCH] net: korina: remove busy skb free Vincent Stehlé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201216150215.6b7f724d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=jwi@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=vincent.stehle@laposte.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).