From: kernel test robot <lkp@intel.com>
To: ultrachin@163.com, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, mingo@redhat.com, peterz@infradead.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com
Subject: Re: [PATCH] sched: pull tasks when CPU is about to run SCHED_IDLE tasks
Date: Mon, 28 Dec 2020 03:42:03 +0800 [thread overview]
Message-ID: <202012280330.J0BGS8NI-lkp@intel.com> (raw)
In-Reply-To: <1608710968-31475-1-git-send-email-ultrachin@163.com>
[-- Attachment #1: Type: text/plain, Size: 2697 bytes --]
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/sched/core]
[also build test ERROR on tip/master linux/master linus/master v5.10 next-20201223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/ultrachin-163-com/sched-pull-tasks-when-CPU-is-about-to-run-SCHED_IDLE-tasks/20201223-175522
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 5b78f2dc315354c05300795064f587366a02c6ff
config: microblaze-randconfig-r002-20201223 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3dc62b606dd00e8c8935ff6b85d8bf26a960842b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review ultrachin-163-com/sched-pull-tasks-when-CPU-is-about-to-run-SCHED_IDLE-tasks/20201223-175522
git checkout 3dc62b606dd00e8c8935ff6b85d8bf26a960842b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=microblaze
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
kernel/sched/fair.c: In function 'pick_next_task_fair':
kernel/sched/fair.c:7034:6: error: implicit declaration of function 'sched_idle_cpu'; did you mean 'sched_idle_rq'? [-Werror=implicit-function-declaration]
7034 | sched_idle_cpu(rq->cpu))
| ^~~~~~~~~~~~~~
| sched_idle_rq
>> kernel/sched/fair.c:7034:23: error: 'struct rq' has no member named 'cpu'
7034 | sched_idle_cpu(rq->cpu))
| ^~
cc1: some warnings being treated as errors
vim +7034 kernel/sched/fair.c
7023
7024 struct task_struct *
7025 pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf)
7026 {
7027 struct cfs_rq *cfs_rq = &rq->cfs;
7028 struct sched_entity *se;
7029 struct task_struct *p;
7030 int new_tasks;
7031
7032 if (prev &&
7033 fair_policy(prev->policy) &&
> 7034 sched_idle_cpu(rq->cpu))
7035 goto idle;
7036
7037 again:
7038 if (!sched_fair_runnable(rq))
7039 goto idle;
7040
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30107 bytes --]
prev parent reply other threads:[~2020-12-27 19:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 8:09 [PATCH] sched: pull tasks when CPU is about to run SCHED_IDLE tasks ultrachin
2020-12-23 11:30 ` Vincent Guittot
2021-01-11 8:26 ` chin
2021-01-11 11:04 ` Vincent Guittot
2021-01-12 6:57 ` chin
2021-01-12 8:18 ` Vincent Guittot
2021-01-13 3:12 ` chin
2021-01-13 8:30 ` Vincent Guittot
2021-02-02 7:54 ` chin
2021-02-02 15:54 ` Vincent Guittot
2021-02-03 2:53 ` chin
2021-02-04 3:57 ` Jiang Biao
2021-02-04 8:03 ` Vincent Guittot
2021-02-04 8:01 ` Vincent Guittot
2021-02-04 8:52 ` chin
2021-02-04 9:02 ` Vincent Guittot
2021-02-04 9:13 ` Jiang Biao
2021-01-11 9:15 ` He Chen
2020-12-27 19:13 ` kernel test robot
2020-12-27 19:42 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012280330.J0BGS8NI-lkp@intel.com \
--to=lkp@intel.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=ultrachin@163.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).