From: Nikita Shubin <nikita.shubin@maquefel.me>
To: unlisted-recipients:; (no To-header on input)
Cc: Nikita Shubin <nikita.shubin@maquefel.me>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Thierry Reding <treding@nvidia.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] gpiolib: warning on gpiochip->to_irq defined
Date: Mon, 28 Dec 2020 18:00:52 +0300 [thread overview]
Message-ID: <20201228150052.2633-1-nikita.shubin@maquefel.me> (raw)
gpiochip->to_irq method is redefined in gpiochip_add_irqchip.
A lot of gpiod driver's still define ->to_irq method, let's give
a gentle warning that they can no longer rely on it, so they can remove
it on ocassion.
Fixes: e0d8972898139 ("gpio: Implement tighter IRQ chip integration")
Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
---
drivers/gpio/gpiolib.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 5ce0c14c637b..44538d1a771a 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1489,6 +1489,9 @@ static int gpiochip_add_irqchip(struct gpio_chip *gc,
type = IRQ_TYPE_NONE;
}
+ if (gc->to_irq)
+ chip_err(gc, "to_irq is redefined in %s and you shouldn't rely on it\n", __func__);
+
gc->to_irq = gpiochip_to_irq;
gc->irq.default_type = type;
gc->irq.lock_key = lock_key;
--
2.29.2
next reply other threads:[~2020-12-28 15:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 15:00 Nikita Shubin [this message]
2021-01-04 14:15 ` [PATCH] gpiolib: warning on gpiochip->to_irq defined Bartosz Golaszewski
2021-01-18 9:05 ` [PATCH v2] " Nikita Shubin
2021-01-19 10:51 ` Bartosz Golaszewski
2021-01-27 10:46 ` [PATCH v2 0/9] gpio: ep93xx: fixes series patch Nikita Shubin
2021-01-27 10:46 ` [PATCH v2 1/9] gpio: ep93xx: fix BUG_ON port F usage Nikita Shubin
2021-01-27 10:46 ` [PATCH v2 2/9] gpio: ep93xx: Fix single irqchip with multi gpiochips Nikita Shubin
2021-01-27 21:39 ` Alexander Sverdlin
2021-01-28 10:17 ` Alexander Sverdlin
2021-01-27 10:46 ` [PATCH v2 3/9] gpio: ep93xx: Fix wrong irq numbers in port F Nikita Shubin
2021-01-27 21:50 ` Linus Walleij
2021-01-28 10:15 ` Alexander Sverdlin
2021-01-27 10:46 ` [PATCH v2 4/9] gpio: ep93xx: drop to_irq binding Nikita Shubin
2021-01-27 12:21 ` Alexander Sverdlin
2021-01-27 10:46 ` [PATCH v2 5/9] gpio: ep93xx: Fix typo s/hierarchial/hierarchical Nikita Shubin
2021-01-27 13:20 ` Alexander Sverdlin
2021-01-27 10:46 ` [PATCH v2 6/9] gpio: ep93xx: refactor ep93xx_gpio_add_bank Nikita Shubin
2021-01-27 13:24 ` Alexander Sverdlin
2021-01-27 10:46 ` [PATCH v2 7/9] gpio: ep93xx: separate IRQ's setup Nikita Shubin
2021-01-27 20:48 ` Alexander Sverdlin
2021-01-27 10:46 ` [PATCH v2 8/9] gpio: ep93xx: refactor base IRQ number Nikita Shubin
2021-01-27 11:36 ` Alexander Sverdlin
2021-01-27 10:46 ` [PATCH v2 9/9] gpio: ep93xx: replace bools with idx for IRQ ports Nikita Shubin
2021-01-27 11:34 ` Alexander Sverdlin
2021-01-27 21:54 ` [PATCH v2 0/9] gpio: ep93xx: fixes series patch Linus Walleij
2021-01-28 10:19 ` Alexander Sverdlin
2021-01-28 11:57 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201228150052.2633-1-nikita.shubin@maquefel.me \
--to=nikita.shubin@maquefel.me \
--cc=bgolaszewski@baylibre.com \
--cc=grygorii.strashko@ti.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).