From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9193C43332 for ; Mon, 4 Jan 2021 16:20:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74071221F1 for ; Mon, 4 Jan 2021 16:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728147AbhADQUO (ORCPT ); Mon, 4 Jan 2021 11:20:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726434AbhADQUN (ORCPT ); Mon, 4 Jan 2021 11:20:13 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9951C061574; Mon, 4 Jan 2021 08:19:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LWMq7OUBtnVBBG+dc0YhdlqaMzMMUhts72RYl0AtdPM=; b=fDlHzLIRBoULufXAaGLtu2g9lo yWtvh2rGpxlyYyJzI6muWm8UhXfZl8EY1Uf8s6lM4d56Ju3tavW49tP2tITyeJrTVdWvvf/SkrdbN w9GyOcRUToqvJBIrnwCheNjZWrMmlKCzwmF83ON93iMipal4oqwNCrINqceuYAk1RSpR9PINvdA1E HG2HzF2SGlTHzlI+frhpw96JXRyHP9itESJNjefRlIHroF4aohOLaWgQSKaCLiNBmM7VIPeI31U1X LMfhunOHJEL5DnX6tKtACwCWTlfBFIfuPSBbujxw7kPWIh7VzeU+g0VxNw04YZ1kBf95uS16G6N3j eprUSEJg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1kwSYt-000HxM-Si; Mon, 04 Jan 2021 16:18:29 +0000 Date: Mon, 4 Jan 2021 16:18:27 +0000 From: Christoph Hellwig To: Pavel Begunkov Cc: linux-block@vger.kernel.org, Jens Axboe , Christoph Hellwig , Matthew Wilcox , Ming Lei , Johannes Weiner , Alexander Viro , "Darrick J . Wong" , "Martin K . Petersen" , Jonathan Corbet , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, target-devel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v2 2/7] bvec/iter: disallow zero-length segment bvecs Message-ID: <20210104161827.GB68600@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 02, 2021 at 03:17:34PM +0000, Pavel Begunkov wrote: > zero-length bvec segments are allowed in general, but not handled by bio > and down the block layer so filtered out. This inconsistency may be > confusing and prevent from optimisations. As zero-length segments are > useless and places that were generating them are patched, declare them > not allowed. Looks good, Reviewed-by: Christoph Hellwig