From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: agross@kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH v2 18/18] ARM: dts: qcom: sdx55-mtp: Add regulator nodes
Date: Wed, 6 Jan 2021 16:24:40 +0530 [thread overview]
Message-ID: <20210106105440.GD3131@thinkpad> (raw)
In-Reply-To: <X/Ss6ycyQF87cYxx@builder.lan>
On Tue, Jan 05, 2021 at 12:16:11PM -0600, Bjorn Andersson wrote:
> On Tue 05 Jan 06:26 CST 2021, Manivannan Sadhasivam wrote:
>
> > From: Vinod Koul <vkoul@kernel.org>
> >
> > This adds the regulators found on SDX55 MTP.
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > arch/arm/boot/dts/qcom-sdx55-mtp.dts | 179 +++++++++++++++++++++++++++
> > 1 file changed, 179 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/qcom-sdx55-mtp.dts b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> > index 825cc7d0ba18..61e7d5d4bd48 100644
> > --- a/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> > +++ b/arch/arm/boot/dts/qcom-sdx55-mtp.dts
> > @@ -6,6 +6,7 @@
> >
> > /dts-v1/;
> >
> > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> > #include "qcom-sdx55.dtsi"
> > #include <arm64/qcom/pm8150b.dtsi>
> > #include "qcom-pmx55.dtsi"
> > @@ -22,6 +23,184 @@ aliases {
> > chosen {
> > stdout-path = "serial0:115200n8";
> > };
> > +
> > + vph_pwr: vph-pwr-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vph_pwr";
> > + regulator-min-microvolt = <3700000>;
> > + regulator-max-microvolt = <3700000>;
> > + };
> > +
> > + vreg_bob_3p3: pmx55-bob {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vreg_bob_3p3";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > +
> > + regulator-always-on;
> > + regulator-boot-on;
> > +
> > + vin-supply = <&vph_pwr>;
> > + };
> > +
> > + vreg_s7e_mx_0p752: pmx55-s7e {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vreg_s7e_mx_0p752";
> > + regulator-min-microvolt = <752000>;
> > + regulator-max-microvolt = <752000>;
> > +
> > + vin-supply = <&vph_pwr>;
> > + };
> > +
> > + vreg_vddpx_2: vddpx-2 {
>
> Isn't this the name of the pad on the SoC, i.e. the consumer? Does the
> regulator output have a more suitable name?
>
The reference is from the downstream dts.
> I don't see any references to this node and you got it "boot-on", what
> happens when the regulator core tuns it off? Or this isn't an issue
> until we actually try to support sdhci (guessing based on the voltages)?
>
I think we can ignore this regulator since there is no SDHCI support in MTP.
Thanks,
Mani
> Regards,
> Bjorn
>
> > + compatible = "regulator-gpio";
> > + regulator-name = "vreg_vddpx_2";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <2850000>;
> > + enable-gpios = <&tlmm 98 GPIO_ACTIVE_HIGH>;
> > + gpios = <&tlmm 100 GPIO_ACTIVE_HIGH>;
> > + states = <1800000 0>, <2850000 1>;
> > + startup-delay-us = <200000>;
> > + enable-active-high;
> > + regulator-boot-on;
> > +
> > + vin-supply = <&vph_pwr>;
> > + };
> > +};
> > +
> > +&apps_rsc {
> > + pmx55-rpmh-regulators {
> > + compatible = "qcom,pmx55-rpmh-regulators";
> > + qcom,pmic-id = "e";
> > +
> > + vdd-s1-supply = <&vph_pwr>;
> > + vdd-s2-supply = <&vph_pwr>;
> > + vdd-s3-supply = <&vph_pwr>;
> > + vdd-s4-supply = <&vph_pwr>;
> > + vdd-s5-supply = <&vph_pwr>;
> > + vdd-s6-supply = <&vph_pwr>;
> > + vdd-s7-supply = <&vph_pwr>;
> > + vdd-l1-l2-supply = <&vreg_s2e_1p224>;
> > + vdd-l3-l9-supply = <&vreg_s3e_0p824>;
> > + vdd-l4-l12-supply = <&vreg_s4e_1p904>;
> > + vdd-l5-l6-supply = <&vreg_s4e_1p904>;
> > + vdd-l7-l8-supply = <&vreg_s3e_0p824>;
> > + vdd-l10-l11-l13-supply = <&vreg_bob_3p3>;
> > + vdd-l14-supply = <&vreg_s7e_mx_0p752>;
> > + vdd-l15-supply = <&vreg_s2e_1p224>;
> > + vdd-l16-supply = <&vreg_s4e_1p904>;
> > +
> > + vreg_s2e_1p224: smps2 {
> > + regulator-min-microvolt = <1280000>;
> > + regulator-max-microvolt = <1400000>;
> > + };
> > +
> > + vreg_s3e_0p824: smps3 {
> > + regulator-min-microvolt = <800000>;
> > + regulator-max-microvolt = <1000000>;
> > + };
> > +
> > + vreg_s4e_1p904: smps4 {
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1960000>;
> > + };
> > +
> > + ldo1 {
> > + regulator-min-microvolt = <1200000>;
> > + regulator-max-microvolt = <1200000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo2 {
> > + regulator-min-microvolt = <1128000>;
> > + regulator-max-microvolt = <1128000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo3 {
> > + regulator-min-microvolt = <800000>;
> > + regulator-max-microvolt = <800000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo4 {
> > + regulator-min-microvolt = <872000>;
> > + regulator-max-microvolt = <872000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo5 {
> > + regulator-min-microvolt = <1704000>;
> > + regulator-max-microvolt = <1900000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo6 {
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo7 {
> > + regulator-min-microvolt = <480000>;
> > + regulator-max-microvolt = <900000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo8 {
> > + regulator-min-microvolt = <480000>;
> > + regulator-max-microvolt = <900000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo9 {
> > + regulator-min-microvolt = <800000>;
> > + regulator-max-microvolt = <800000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo10 {
> > + regulator-min-microvolt = <3088000>;
> > + regulator-max-microvolt = <3088000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo11 {
> > + regulator-min-microvolt = <1704000>;
> > + regulator-max-microvolt = <2928000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo12 {
> > + regulator-min-microvolt = <1200000>;
> > + regulator-max-microvolt = <1200000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo13 {
> > + regulator-min-microvolt = <1704000>;
> > + regulator-max-microvolt = <2928000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo14 {
> > + regulator-min-microvolt = <600000>;
> > + regulator-max-microvolt = <800000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo15 {
> > + regulator-min-microvolt = <1200000>;
> > + regulator-max-microvolt = <1200000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > +
> > + ldo16 {
> > + regulator-min-microvolt = <1704000>;
> > + regulator-max-microvolt = <1904000>;
> > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>;
> > + };
> > + };
> > };
> >
> > &blsp1_uart3 {
> > --
> > 2.25.1
> >
prev parent reply other threads:[~2021-01-06 10:55 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 12:26 [PATCH v2 00/18] Devicetree update for SDX55 platform Manivannan Sadhasivam
2021-01-05 12:26 ` [PATCH v2 01/18] ARM: dts: qcom: sdx55: Add pincontrol node Manivannan Sadhasivam
2021-01-05 12:26 ` [PATCH v2 02/18] ARM: dts: qcom: sdx55: Add reserved memory nodes Manivannan Sadhasivam
2021-01-05 18:05 ` Bjorn Andersson
2021-01-06 3:07 ` Manivannan Sadhasivam
2021-01-06 3:42 ` Bjorn Andersson
2021-01-06 7:18 ` Manivannan Sadhasivam
2021-01-05 12:26 ` [PATCH v2 03/18] dt-bindings: mmc: sdhci-msm: Document the SDX55 compatible Manivannan Sadhasivam
2021-01-05 15:53 ` Vinod Koul
2021-01-05 12:26 ` [PATCH v2 04/18] ARM: dts: qcom: sdx55: Add support for SDHCI controller Manivannan Sadhasivam
2021-01-05 15:52 ` Vinod Koul
2021-01-06 10:26 ` Manivannan Sadhasivam
2021-01-05 12:26 ` [PATCH v2 05/18] dt-bindings: arm-smmu: Add binding for Qcom SDX55 SMMU Manivannan Sadhasivam
2021-01-05 15:49 ` Vinod Koul
2021-01-05 12:26 ` [PATCH v2 06/18] ARM: dts: qcom: sdx55: Enable ARM SMMU Manivannan Sadhasivam
2021-01-05 12:26 ` [PATCH v2 07/18] ARM: dts: qcom: sdx55: Add support for TCSR Mutex Manivannan Sadhasivam
2021-01-05 15:52 ` Vinod Koul
2021-01-05 18:20 ` Bjorn Andersson
2021-01-05 12:26 ` [PATCH v2 08/18] ARM: dts: qcom: sdx55: Add Shared memory manager support Manivannan Sadhasivam
2021-01-05 15:51 ` Vinod Koul
2021-01-05 12:26 ` [PATCH v2 09/18] ARM: dts: qcom: sdx55: Add QPIC BAM support Manivannan Sadhasivam
2021-01-05 15:50 ` Vinod Koul
2021-01-05 15:55 ` Vinod Koul
2021-01-05 12:26 ` [PATCH v2 10/18] ARM: dts: qcom: sdx55: Add QPIC NAND support Manivannan Sadhasivam
2021-01-05 15:51 ` Vinod Koul
2021-01-06 7:29 ` Manivannan Sadhasivam
2021-01-05 12:26 ` [PATCH v2 11/18] ARM: dts: qcom: sdx55-mtp: Enable BAM DMA Manivannan Sadhasivam
2021-01-05 15:51 ` Vinod Koul
2021-01-05 12:26 ` [PATCH v2 12/18] ARM: dts: qcom: sdx55-mtp: Enable QPIC NAND Manivannan Sadhasivam
2021-01-05 15:51 ` Vinod Koul
2021-01-05 12:26 ` [PATCH v2 13/18] ARM: dts: qcom: sdx55: Add spmi node Manivannan Sadhasivam
2021-01-05 12:26 ` [PATCH v2 14/18] ARM: dts: qcom: sdx55-mtp: Add pm8150b pmic Manivannan Sadhasivam
2021-01-05 12:26 ` [PATCH v2 15/18] ARM: dts: qcom: sdx55-mtp: Add pmx55 pmic Manivannan Sadhasivam
2021-01-05 12:26 ` [PATCH v2 16/18] ARM: dts: qcom: sdx55: Add rpmpd node Manivannan Sadhasivam
2021-01-05 12:26 ` [PATCH v2 17/18] ARM: dts: qcom: Add PMIC pmx55 dts Manivannan Sadhasivam
2021-01-05 18:10 ` Bjorn Andersson
2021-01-05 12:26 ` [PATCH v2 18/18] ARM: dts: qcom: sdx55-mtp: Add regulator nodes Manivannan Sadhasivam
2021-01-05 18:16 ` Bjorn Andersson
2021-01-06 10:54 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210106105440.GD3131@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).