From: Calvin Johnson <calvin.johnson@oss.nxp.com>
To: Grant Likely <grant.likely@arm.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Jeremy Linton <jeremy.linton@arm.com>,
Andrew Lunn <andrew@lunn.ch>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Russell King - ARM Linux admin <linux@armlinux.org.uk>,
Cristi Sovaiala <cristian.sovaiala@nxp.com>,
Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Madalin Bucur <madalin.bucur@oss.nxp.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Marcin Wojtas <mw@semihalf.com>,
Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>,
Jon <jon@solid-run.com>
Cc: Diana Madalina Craciun <diana.craciun@nxp.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Laurentiu Tudor <laurentiu.tudor@nxp.com>,
linux-acpi@vger.kernel.org, linux.cj@gmail.com,
linux-arm-kernel@lists.infradead.org,
Calvin Johnson <calvin.johnson@oss.nxp.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Randy Dunlap <rdunlap@infradead.org>,
Saravana Kannan <saravanak@google.com>
Subject: [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id()
Date: Tue, 12 Jan 2021 19:10:48 +0530 [thread overview]
Message-ID: <20210112134054.342-10-calvin.johnson@oss.nxp.com> (raw)
In-Reply-To: <20210112134054.342-1-calvin.johnson@oss.nxp.com>
Using fwnode_get_id(), get the reg property value for DT node
or get the _ADR object value for ACPI node.
Signed-off-by: Calvin Johnson <calvin.johnson@oss.nxp.com>
---
Changes in v3:
- Modified to retrieve reg property value for ACPI as well
- Resolved compilation issue with CONFIG_ACPI = n
- Added more info into documentation
Changes in v2: None
drivers/base/property.c | 33 +++++++++++++++++++++++++++++++++
include/linux/property.h | 1 +
2 files changed, 34 insertions(+)
diff --git a/drivers/base/property.c b/drivers/base/property.c
index 35b95c6ac0c6..2d51108cb936 100644
--- a/drivers/base/property.c
+++ b/drivers/base/property.c
@@ -580,6 +580,39 @@ const char *fwnode_get_name_prefix(const struct fwnode_handle *fwnode)
return fwnode_call_ptr_op(fwnode, get_name_prefix);
}
+/**
+ * fwnode_get_id - Get the id of a fwnode.
+ * @fwnode: firmware node
+ * @id: id of the fwnode
+ *
+ * This function provides the id of a fwnode which can be either
+ * DT or ACPI node. For ACPI, "reg" property value, if present will
+ * be provided or else _ADR value will be provided.
+ * Returns 0 on success or a negative errno.
+ */
+int fwnode_get_id(struct fwnode_handle *fwnode, u32 *id)
+{
+#ifdef CONFIG_ACPI
+ unsigned long long adr;
+ acpi_status status;
+#endif
+ int ret;
+
+ ret = fwnode_property_read_u32(fwnode, "reg", id);
+ if (!(ret && is_acpi_node(fwnode)))
+ return ret;
+
+#ifdef CONFIG_ACPI
+ status = acpi_evaluate_integer(ACPI_HANDLE_FWNODE(fwnode),
+ METHOD_NAME__ADR, NULL, &adr);
+ if (ACPI_FAILURE(status))
+ return -EINVAL;
+ *id = (u32)adr;
+#endif
+ return 0;
+}
+EXPORT_SYMBOL_GPL(fwnode_get_id);
+
/**
* fwnode_get_parent - Return parent firwmare node
* @fwnode: Firmware whose parent is retrieved
diff --git a/include/linux/property.h b/include/linux/property.h
index 0a9001fe7aea..3f41475f010b 100644
--- a/include/linux/property.h
+++ b/include/linux/property.h
@@ -82,6 +82,7 @@ struct fwnode_handle *fwnode_find_reference(const struct fwnode_handle *fwnode,
const char *fwnode_get_name(const struct fwnode_handle *fwnode);
const char *fwnode_get_name_prefix(const struct fwnode_handle *fwnode);
+int fwnode_get_id(struct fwnode_handle *fwnode, u32 *id);
struct fwnode_handle *fwnode_get_parent(const struct fwnode_handle *fwnode);
struct fwnode_handle *fwnode_get_next_parent(
struct fwnode_handle *fwnode);
--
2.17.1
next prev parent reply other threads:[~2021-01-12 13:43 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 13:40 [net-next PATCH v3 00/15] ACPI support for dpaa2 driver Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 01/15] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson
2021-01-18 22:12 ` Randy Dunlap
2021-01-12 13:40 ` [net-next PATCH v3 02/15] net: phy: Introduce fwnode_mdio_find_device() Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 03/15] net: phy: Introduce phy related fwnode functions Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 04/15] of: mdio: Refactor of_phy_find_device() Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 05/15] net: phy: Introduce fwnode_get_phy_id() Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 06/15] of: mdio: Refactor of_get_phy_id() Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 08/15] of: mdio: Refactor of_mdiobus_register_phy() Calvin Johnson
2021-01-12 13:40 ` Calvin Johnson [this message]
2021-01-12 15:48 ` [net-next PATCH v3 09/15] device property: Introduce fwnode_get_id() Andy Shevchenko
2021-01-20 18:17 ` Rafael J. Wysocki
2021-01-20 18:45 ` Andy Shevchenko
2021-01-20 19:12 ` Rafael J. Wysocki
2021-01-12 17:30 ` Saravana Kannan
2021-01-12 18:03 ` Andy Shevchenko
2021-01-20 18:18 ` Rafael J. Wysocki
2021-01-20 18:52 ` Andy Shevchenko
2021-01-20 19:15 ` Rafael J. Wysocki
2021-01-20 20:01 ` Saravana Kannan
2021-01-22 16:34 ` Rafael J. Wysocki
2021-01-22 20:58 ` Saravana Kannan
2021-01-22 21:06 ` Andy Shevchenko
2021-01-22 21:07 ` Saravana Kannan
2021-01-15 10:47 ` Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 10/15] net: mdio: Add ACPI support code for mdio Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 11/15] net: mdiobus: Introduce fwnode_mdiobus_register() Calvin Johnson
2021-01-12 15:52 ` Andy Shevchenko
2021-01-12 13:40 ` [net-next PATCH v3 12/15] net/fsl: Use fwnode_mdiobus_register() Calvin Johnson
2021-01-12 15:53 ` Andy Shevchenko
2021-01-12 13:40 ` [net-next PATCH v3 13/15] phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson
2021-01-12 15:55 ` Andy Shevchenko
2021-01-19 4:05 ` Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 14/15] net: phylink: Refactor phylink_of_phy_connect() Calvin Johnson
2021-01-12 15:57 ` Andy Shevchenko
2021-01-19 4:08 ` Calvin Johnson
2021-01-12 13:40 ` [net-next PATCH v3 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112134054.342-10-calvin.johnson@oss.nxp.com \
--to=calvin.johnson@oss.nxp.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=cristian.sovaiala@nxp.com \
--cc=diana.craciun@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=florinlaurentiu.chiculita@nxp.com \
--cc=grant.likely@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=ioana.ciornei@nxp.com \
--cc=jeremy.linton@arm.com \
--cc=jon@solid-run.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.cj@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@oss.nxp.com \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=pieter.jansenvv@bamboosystems.io \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).