From: Steven Rostedt <rostedt@goodmis.org>
To: Alexander Potapenko <glider@google.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Marco Elver <elver@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>,
Ingo Molnar <mingo@redhat.com>, Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-mm@kvack.org
Subject: Re: [PATCH 1/4] tracing: add error_report trace points
Date: Wed, 13 Jan 2021 16:10:44 -0500 [thread overview]
Message-ID: <20210113161044.43bc1c1a@gandalf.local.home> (raw)
In-Reply-To: <20210113091657.1456216-2-glider@google.com>
On Wed, 13 Jan 2021 10:16:54 +0100
Alexander Potapenko <glider@google.com> wrote:
> +DECLARE_EVENT_CLASS(error_report_template,
> + TP_PROTO(const char *error_detector, unsigned long id),
Instead of having a random string, as this should be used by a small finite
set of subsystems, why not make the above into an enum?
> + TP_ARGS(error_detector, id),
> + TP_STRUCT__entry(__field(const char *, error_detector)
> + __field(unsigned long, id)),
> + TP_fast_assign(__entry->error_detector = error_detector;
> + __entry->id = id;),
> + TP_printk("[%s] %lx", __entry->error_detector,
Then the [%s] portion of this could also be just a __print_symbolic().
-- Steve
> + __entry->id));
> +
> +/**
next prev parent reply other threads:[~2021-01-14 2:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-13 9:16 [PATCH 0/4] Add sysfs interface to collect reports from debugging tools Alexander Potapenko
2021-01-13 9:16 ` [PATCH 1/4] tracing: add error_report trace points Alexander Potapenko
2021-01-13 21:10 ` Steven Rostedt [this message]
2021-01-14 7:49 ` Alexander Potapenko
2021-01-14 8:59 ` Marco Elver
2021-01-14 14:52 ` Steven Rostedt
2021-01-15 12:53 ` Alexander Potapenko
2021-01-15 16:17 ` Steven Rostedt
2021-01-13 9:16 ` [PATCH 2/4] lib: add error_report_notify to collect debugging tools' reports Alexander Potapenko
2021-01-14 0:06 ` Andrew Morton
2021-01-14 9:51 ` Alexander Potapenko
2021-01-15 10:18 ` Alexander Potapenko
2021-01-13 9:16 ` [PATCH 3/4] kfence: use error_report_start and error_report_end tracepoints Alexander Potapenko
2021-01-13 9:16 ` [PATCH 4/4] kasan: " Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210113161044.43bc1c1a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).