From: David Gibson <david@gibson.dropbear.id.au>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Masahiro Yamada <masahiroy@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Bill Mills <bill.mills@linaro.org>,
anmar.oueja@linaro.org
Subject: Re: [PATCH V5 5/5] of: unittest: Statically apply overlays using fdtoverlay
Date: Fri, 22 Jan 2021 10:39:57 +1100 [thread overview]
Message-ID: <20210121233957.GA4400@yekko.fritz.box> (raw)
In-Reply-To: <20210121065728.trqph5uwvp43k46l@vireshk-i7>
[-- Attachment #1: Type: text/plain, Size: 1248 bytes --]
On Thu, Jan 21, 2021 at 12:27:28PM +0530, Viresh Kumar wrote:
> On 21-01-21, 17:34, David Gibson wrote:
> > No, this is the wrong way around. The expected operation here is that
> > you apply overlay (1) to the base tree, giving you, say, output1.dtb.
> > output1.dtb is (effectively) a base tree itself, to which you can then
> > apply overlay-(2).
>
> Thanks for the confirmation about this.
>
> > Merging overlays is
> > something that could make sense, but fdtoverlay will not do it at
> > present.
>
> FWIW, I think it works fine right now even if it not intentional.
No, it definitely will not work in general. It might kinda work in a
few trivial cases, but it absolutely will not do the neccessary
handling in some cases.
> I
> did inspect the output dtb (made by merging two overlays) using
> fdtdump and it looked okay.
Ok.. but if you're using these bizarre messed up "dtbs" that this test
code seems to be, I don't really trust that tells you much.
> But yeah, I understand that we shouldn't
> do it.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-21 23:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 7:06 [PATCH V5 0/5] dt: build overlays Viresh Kumar
2021-01-20 7:06 ` [PATCH V5 1/5] scripts: dtc: Fetch fdtoverlay.c from external DTC project Viresh Kumar
2021-01-20 7:06 ` [PATCH V5 2/5] scripts: dtc: Build fdtoverlay tool Viresh Kumar
2021-01-20 7:06 ` [PATCH V5 3/5] scripts: dtc: Remove the unused fdtdump.c file Viresh Kumar
2021-01-21 0:44 ` David Gibson
2021-01-21 4:17 ` Viresh Kumar
2021-01-21 6:26 ` David Gibson
2021-01-21 14:18 ` Rob Herring
2021-01-20 7:06 ` [PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo) Viresh Kumar
2021-01-20 8:58 ` Masahiro Yamada
2021-01-20 9:55 ` Viresh Kumar
2021-01-20 11:04 ` Masahiro Yamada
2021-01-20 11:27 ` Viresh Kumar
2021-01-21 0:49 ` David Gibson
2021-01-21 4:13 ` Viresh Kumar
2021-01-21 5:40 ` Frank Rowand
2021-01-21 6:25 ` David Gibson
2021-01-20 7:06 ` [PATCH V5 5/5] of: unittest: Statically apply overlays using fdtoverlay Viresh Kumar
2021-01-21 0:51 ` David Gibson
2021-01-21 5:14 ` Frank Rowand
2021-01-21 5:34 ` Viresh Kumar
2021-01-21 5:45 ` Frank Rowand
2021-01-21 5:50 ` Viresh Kumar
2021-01-21 6:36 ` David Gibson
2021-01-21 6:34 ` David Gibson
2021-01-21 6:57 ` Viresh Kumar
2021-01-21 23:39 ` David Gibson [this message]
2021-01-22 3:10 ` Viresh Kumar
2021-01-22 4:27 ` David Gibson
2021-01-21 5:34 ` Frank Rowand
2021-01-21 5:43 ` Viresh Kumar
2021-01-21 5:55 ` Frank Rowand
2021-01-21 5:58 ` Viresh Kumar
2021-01-21 7:04 ` Frank Rowand
2021-01-21 23:41 ` David Gibson
2021-01-21 6:37 ` David Gibson
2021-01-20 15:43 ` [PATCH V5 0/5] dt: build overlays Rob Herring
2021-01-21 4:14 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121233957.GA4400@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=anmar.oueja@linaro.org \
--cc=bill.mills@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).