From: Zheng Yongjun <zhengyongjun3@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>,
<linux-decnet-user@lists.sourceforge.net>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: Zheng Yongjun <zhengyongjun3@huawei.com>
Subject: [PATCH net-next] net: Return the correct errno code
Date: Thu, 4 Feb 2021 16:56:30 +0800 [thread overview]
Message-ID: <20210204085630.19452-1-zhengyongjun3@huawei.com> (raw)
When kzalloc failed, should return ENOMEM rather than ENOBUFS.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
net/decnet/dn_dev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c
index 15d42353f1a3..50e375dcd5bd 100644
--- a/net/decnet/dn_dev.c
+++ b/net/decnet/dn_dev.c
@@ -469,7 +469,7 @@ int dn_dev_ioctl(unsigned int cmd, void __user *arg)
case SIOCSIFADDR:
if (!ifa) {
if ((ifa = dn_dev_alloc_ifa()) == NULL) {
- ret = -ENOBUFS;
+ ret = -ENOMEM;
break;
}
memcpy(ifa->ifa_label, dev->name, IFNAMSIZ);
@@ -645,7 +645,7 @@ static int dn_nl_newaddr(struct sk_buff *skb, struct nlmsghdr *nlh,
}
if ((ifa = dn_dev_alloc_ifa()) == NULL)
- return -ENOBUFS;
+ return -ENOMEM;
if (tb[IFA_ADDRESS] == NULL)
tb[IFA_ADDRESS] = tb[IFA_LOCAL];
@@ -1088,7 +1088,7 @@ static struct dn_dev *dn_dev_create(struct net_device *dev, int *err)
if (i == DN_DEV_LIST_SIZE)
return NULL;
- *err = -ENOBUFS;
+ *err = -ENOMEM;
if ((dn_db = kzalloc(sizeof(struct dn_dev), GFP_ATOMIC)) == NULL)
return NULL;
--
2.22.0
next reply other threads:[~2021-02-04 8:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 8:56 Zheng Yongjun [this message]
2021-02-04 19:14 ` [PATCH net-next] net: Return the correct errno code Jesse Brandeburg
2021-02-06 19:18 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2021-06-02 14:06 Zheng Yongjun
2021-06-03 22:20 ` patchwork-bot+netdevbpf
2021-06-01 14:14 Zheng Yongjun
2021-06-02 0:10 ` patchwork-bot+netdevbpf
2021-02-04 7:32 Zheng Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204085630.19452-1-zhengyongjun3@huawei.com \
--to=zhengyongjun3@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-decnet-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).