linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Lecopzer Chen <lecopzer@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
	dan.j.williams@intel.com, aryabinin@virtuozzo.com,
	glider@google.com, dvyukov@google.com, akpm@linux-foundation.org,
	linux-mediatek@lists.infradead.org, yj.chiang@mediatek.com,
	catalin.marinas@arm.com, ardb@kernel.org, andreyknvl@google.com,
	broonie@kernel.org, linux@roeck-us.net, rppt@kernel.org,
	tyhicks@linux.microsoft.com, robin.murphy@arm.com,
	vincenzo.frascino@arm.com, gustavoars@kernel.org,
	Lecopzer Chen <lecopzer.chen@mediatek.com>
Subject: Re: [PATCH v2 2/4] arm64: kasan: abstract _text and _end to KERNEL_START/END
Date: Thu, 4 Feb 2021 12:46:58 +0000	[thread overview]
Message-ID: <20210204124658.GB20468@willie-the-truck> (raw)
In-Reply-To: <20210109103252.812517-3-lecopzer@gmail.com>

On Sat, Jan 09, 2021 at 06:32:50PM +0800, Lecopzer Chen wrote:
> Arm64 provide defined macro for KERNEL_START and KERNEL_END,
> thus replace them by the abstration instead of using _text and _end.
> 
> Signed-off-by: Lecopzer Chen <lecopzer.chen@mediatek.com>
> ---
>  arch/arm64/mm/kasan_init.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/mm/kasan_init.c b/arch/arm64/mm/kasan_init.c
> index 39b218a64279..fa8d7ece895d 100644
> --- a/arch/arm64/mm/kasan_init.c
> +++ b/arch/arm64/mm/kasan_init.c
> @@ -218,8 +218,8 @@ static void __init kasan_init_shadow(void)
>  	phys_addr_t pa_start, pa_end;
>  	u64 i;
>  
> -	kimg_shadow_start = (u64)kasan_mem_to_shadow(_text) & PAGE_MASK;
> -	kimg_shadow_end = PAGE_ALIGN((u64)kasan_mem_to_shadow(_end));
> +	kimg_shadow_start = (u64)kasan_mem_to_shadow(KERNEL_START) & PAGE_MASK;
> +	kimg_shadow_end = PAGE_ALIGN((u64)kasan_mem_to_shadow(KERNEL_END));
>  
>  	mod_shadow_start = (u64)kasan_mem_to_shadow((void *)MODULES_VADDR);
>  	mod_shadow_end = (u64)kasan_mem_to_shadow((void *)MODULES_END);
> @@ -241,7 +241,7 @@ static void __init kasan_init_shadow(void)
>  	clear_pgds(KASAN_SHADOW_START, KASAN_SHADOW_END);
>  
>  	kasan_map_populate(kimg_shadow_start, kimg_shadow_end,
> -			   early_pfn_to_nid(virt_to_pfn(lm_alias(_text))));
> +			   early_pfn_to_nid(virt_to_pfn(lm_alias(KERNEL_START))));

To be honest, I think this whole line is pointless. We should be able to
pass NUMA_NO_NODE now that we're not abusing the vmemmap() allocator to
populate the shadow.

Will

  reply	other threads:[~2021-02-04 12:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09 10:32 [PATCH v2 0/4] arm64: kasan: support CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-01-09 10:32 ` [PATCH v2 1/4] arm64: kasan: don't populate vmalloc area for CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-02-03 18:37   ` Ard Biesheuvel
2021-02-04  6:21     ` Lecopzer Chen
2021-02-04 12:45   ` Will Deacon
2021-02-04 14:46     ` Lecopzer Chen
2021-02-04 15:01       ` Will Deacon
2021-02-04 16:37         ` Lecopzer Chen
2021-02-05 17:18           ` Will Deacon
2021-02-05 17:30             ` Andrey Konovalov
2021-02-05 17:43               ` Will Deacon
2021-02-05 20:50                 ` Andrey Konovalov
2021-02-05 18:10             ` Lecopzer Chen
2021-01-09 10:32 ` [PATCH v2 2/4] arm64: kasan: abstract _text and _end to KERNEL_START/END Lecopzer Chen
2021-02-04 12:46   ` Will Deacon [this message]
2021-02-04 14:51     ` Lecopzer Chen
2021-02-04 14:55       ` Will Deacon
2021-02-04 16:06         ` Lecopzer Chen
2021-02-05 17:02           ` Will Deacon
2021-01-09 10:32 ` [PATCH v2 3/4] arm64: Kconfig: support CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-01-09 10:32 ` [PATCH v2 4/4] arm64: kaslr: support randomized module area with KASAN_VMALLOC Lecopzer Chen
2021-01-27 23:04   ` Will Deacon
2021-01-28  8:53     ` Lecopzer Chen
2021-01-28 20:26       ` Will Deacon
2021-01-21 10:19 ` [PATCH v2 0/4] arm64: kasan: support CONFIG_KASAN_VMALLOC Lecopzer Chen
2021-01-21 17:44 ` Andrey Konovalov
2021-01-22 19:05   ` Will Deacon
2021-02-03 18:31 ` Ard Biesheuvel
2021-02-04 12:49 ` Will Deacon
2021-02-04 15:53   ` Lecopzer Chen
2021-02-04 17:57     ` Will Deacon
2021-02-04 18:41       ` Lecopzer Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204124658.GB20468@willie-the-truck \
    --to=will@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=ardb@kernel.org \
    --cc=aryabinin@virtuozzo.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dan.j.williams@intel.com \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=gustavoars@kernel.org \
    --cc=kasan-dev@googlegroups.com \
    --cc=lecopzer.chen@mediatek.com \
    --cc=lecopzer@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@roeck-us.net \
    --cc=robin.murphy@arm.com \
    --cc=rppt@kernel.org \
    --cc=tyhicks@linux.microsoft.com \
    --cc=vincenzo.frascino@arm.com \
    --cc=yj.chiang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).