From: Tony Krowiak <akrowiak@linux.ibm.com>
To: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Cc: stable@vger.kernel.org, borntraeger@de.ibm.com,
cohuck@redhat.com, kwankhede@nvidia.com, pbonzini@redhat.com,
alex.williamson@redhat.com, pasic@linux.vnet.ibm.com,
Tony Krowiak <akrowiak@linux.ibm.com>
Subject: [PATCH 0/1] fix circular lockdep when staring SE guest
Date: Tue, 9 Feb 2021 14:48:29 -0500 [thread overview]
Message-ID: <20210209194830.20271-1-akrowiak@linux.ibm.com> (raw)
Patch f21916ec4826 ("s390/vfio-ap: clean up vfio_ap resources when KVM
pointer invalidated") introduced a change that results in a circular
locking dependency when a Secure Execution guest that is configured with
crypto devices is started. The problem resulted due to the fact that the
patch moved the setting of the guest's AP masks within the protection of
the matrix_dev->lock when the vfio_ap driver is notified that the KVM
pointer has been set. Since it is not critical that setting/clearing of
the guest's AP masks when the driver is notified, the masks will not be
updated under the matrix_dev->lock. The lock is necessary for the
setting/unsetting of the KVM pointer, however, so that will remain in
place.
The dependency chain for the circular lockdep resolved by this patch
is:
#2 vfio_ap_mdev_group_notifier: kvm->lock
matrix_dev->lock
#1: handle_pqap: matrix_dev->lock
kvm_vcpu_ioctl: vcpu->mutex
#0: kvm_s390_cpus_to_pv: vcpu->mutex
kvm_vm_ioctl: kvm->lock
Tony Krowiak (1):
s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks
drivers/s390/crypto/vfio_ap_ops.c | 75 ++++++++++++++++++-------------
1 file changed, 45 insertions(+), 30 deletions(-)
--
2.21.1
next reply other threads:[~2021-02-09 23:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 19:48 Tony Krowiak [this message]
2021-02-09 19:48 ` [PATCH 1/1] s390/vfio-ap: fix circular lockdep when setting/clearing crypto masks Tony Krowiak
2021-02-10 10:53 ` Cornelia Huck
2021-02-10 15:24 ` Halil Pasic
2021-02-10 15:32 ` Halil Pasic
2021-02-10 22:05 ` Tony Krowiak
2021-02-10 22:46 ` Halil Pasic
2021-02-11 14:21 ` Tony Krowiak
2021-02-11 16:47 ` Halil Pasic
2021-02-11 19:18 ` Tony Krowiak
2021-02-10 22:03 ` Tony Krowiak
2021-02-10 20:34 ` Tony Krowiak
2021-02-11 12:23 ` Cornelia Huck
2021-02-11 14:38 ` Tony Krowiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209194830.20271-1-akrowiak@linux.ibm.com \
--to=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).