From: Florian Westphal <fw@strlen.de>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Paul Moore <paul@paul-moore.com>, Phil Sutter <phil@nwl.cc>,
Linux-Audit Mailing List <linux-audit@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
netfilter-devel@vger.kernel.org, sgrubb@redhat.com,
Ondrej Mosnacek <omosnace@redhat.com>,
fw@strlen.de, twoerner@redhat.com,
Eric Paris <eparis@parisplace.org>,
tgraf@infradead.org
Subject: Re: [PATCH ghak124 v3] audit: log nftables configuration change events
Date: Thu, 11 Feb 2021 23:09:30 +0100 [thread overview]
Message-ID: <20210211220930.GC2766@breakpoint.cc> (raw)
In-Reply-To: <20210211202628.GP2015948@madcap2.tricolour.ca>
Richard Guy Briggs <rgb@redhat.com> wrote:
> > > I personally would notify once per transaction. This is easy and quick.
>
> This was the goal. iptables was atomic. nftables appears to no longer
> be so. If I have this wrong, please show how that works.
nftables transactions are atomic, either the entire batch takes effect or not
at all.
The audit_log_nfcfg() calls got added to the the nft monitor infra which
is designed to allow userspace to follow the entire content of the
transaction log.
So, if its just a 'something was changed' event that is needed all of
them can be removed. ATM the audit_log_nfcfg() looks like this:
/* step 3. Start new generation, rules_gen_X now in use. */
net->nft.gencursor = nft_gencursor_next(net);
list_for_each_entry_safe(trans, next, &net->nft.commit_list, list) {
switch (trans->msg_type) {
case NFT_MSG_NEWTABLE:
audit_log_nfcfg();
...
case NFT_MSG_...
audit_log_nfcfg();
..
}
which gives an audit_log for every single change in the batch.
So, if just a summary is needed a single audit_log_nfcfg()
after 'step 3' and outside of the list_for_each_entry_safe() is all
that is needed.
If a summary is wanted as well one could fe. count the number of
transaction types in the batch, e.g. table adds, chain adds, rule
adds etc. and then log a summary count instead.
next prev parent reply other threads:[~2021-02-11 22:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 13:20 [PATCH ghak124 v3] audit: log nftables configuration change events Richard Guy Briggs
2020-06-04 17:03 ` Steve Grubb
2020-06-04 17:57 ` Richard Guy Briggs
2020-06-04 18:51 ` Steve Grubb
2020-06-24 0:34 ` Paul Moore
2020-06-24 10:03 ` Pablo Neira Ayuso
2020-06-24 12:34 ` Richard Guy Briggs
2020-06-24 13:03 ` Pablo Neira Ayuso
2020-06-24 13:26 ` Richard Guy Briggs
2021-02-11 15:16 ` Phil Sutter
2021-02-11 16:29 ` Paul Moore
2021-02-11 20:26 ` Richard Guy Briggs
2021-02-11 22:09 ` Florian Westphal [this message]
2021-02-17 23:41 ` Richard Guy Briggs
2021-02-18 8:22 ` Florian Westphal
2021-02-18 12:42 ` Richard Guy Briggs
2021-02-18 12:52 ` Florian Westphal
2021-02-18 13:28 ` Richard Guy Briggs
2021-02-18 13:41 ` Florian Westphal
2021-02-18 21:20 ` Richard Guy Briggs
2021-02-18 22:42 ` Florian Westphal
2021-02-19 6:26 ` Richard Guy Briggs
2021-02-19 19:25 ` Richard Guy Briggs
2021-02-12 20:48 ` Richard Guy Briggs
2021-02-11 21:02 ` Steve Grubb
2021-02-12 12:11 ` Phil Sutter
2021-02-12 20:54 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211220930.GC2766@breakpoint.cc \
--to=fw@strlen.de \
--cc=eparis@parisplace.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=phil@nwl.cc \
--cc=rgb@redhat.com \
--cc=sgrubb@redhat.com \
--cc=tgraf@infradead.org \
--cc=twoerner@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).