From: Vincent Cheng <vincent.cheng.xh@renesas.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock.
Date: Fri, 12 Feb 2021 23:17:45 -0500 [thread overview]
Message-ID: <20210213041742.GA14189@renesas.com> (raw)
In-Reply-To: <20210212153140.GB23246@hoboy.vegasvil.org>
On Fri, Feb 12, 2021 at 10:31:40AM EST, Richard Cochran wrote:
>On Thu, Feb 11, 2021 at 11:38:44PM -0500, vincent.cheng.xh@renesas.com wrote:
>
>> +static int wait_for_sys_apll_dpll_lock(struct idtcm *idtcm)
>> +{
>> + char *fmt = "%d ms SYS lock timeout: APLL Loss Lock %d DPLL state %d";
>
>Probably you want: const char *fmt
Good point, will change in V2 patch.
>
>> diff --git a/drivers/ptp/ptp_clockmatrix.h b/drivers/ptp/ptp_clockmatrix.h
>> index 645de2c..fb32327 100644
>> --- a/drivers/ptp/ptp_clockmatrix.h
>...
>
>> @@ -123,7 +137,6 @@ struct idtcm_channel {
>> enum pll_mode pll_mode;
>> u8 pll;
>> u16 output_mask;
>> - u8 output_phase_adj[MAX_OUTPUT][4];
>> };
>
>Looks like this removal is unrelated to the patch subject, and so it
>deserves its own small patch.
Ok, will separate into separate patch for V2.
Vincent
next prev parent reply other threads:[~2021-02-13 4:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 4:38 [PATCH net-next 0/2] ptp: ptp_clockmatrix: Fix output 1 PPS alignment vincent.cheng.xh
2021-02-12 4:38 ` [PATCH net-next 1/2] ptp: ptp_clockmatrix: Add wait_for_sys_apll_dpll_lock vincent.cheng.xh
2021-02-12 15:31 ` Richard Cochran
2021-02-13 4:17 ` Vincent Cheng [this message]
2021-02-12 4:38 ` [PATCH net-next 2/2] ptp: ptp_clockmatrix: Add alignment of 1 PPS to idtcm_perout_enable vincent.cheng.xh
2021-02-12 15:32 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210213041742.GA14189@renesas.com \
--to=vincent.cheng.xh@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).