From: Dan Carpenter <dan.carpenter@oracle.com>
To: 17UCS047_Prakash Dubey <prakashdubey1999@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: fwserial: Fix alignment of function parameters
Date: Fri, 19 Feb 2021 14:52:21 +0300 [thread overview]
Message-ID: <20210219115221.GW2087@kadam> (raw)
In-Reply-To: <YC+VX4NpOWX1z3+V@kroah.com>
On Fri, Feb 19, 2021 at 11:39:27AM +0100, Greg KH wrote:
> On Fri, Feb 19, 2021 at 03:25:38PM +0530, 17UCS047_Prakash Dubey wrote:
> > I was unable to align it right below the opening parenthesis, just by using
> > tabs. And when I did that with spaces, the checkpatch yelled at me for
> > using spaces. Any suggestions how to do this without using spaces? I am
> > using vim, I will try to find a workaround meanwhile.
>
Your comment hasn't made it to the list yet. Sometimes there is a delay
or maybe it was blocked for some reason (html email?).
You are allowed to use spaces but you can't have 8 consecutive spaces
and spaces are not allowed before a tab character. The way to align it
is:
ret = wait_event_interruptible_timeout(port->wait_tx,
!test_bit(IN_TX, &port->flags),
10);
[tab x6][space x7]!test_bit(IN_TX, &port->flags)
regards,
dan carpenter
next prev parent reply other threads:[~2021-02-19 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 10:28 [PATCH] staging: fwserial: Fix alignment of function parameters Prakash Dubey
2021-02-19 8:13 ` Greg KH
[not found] ` <CALVjNJP=iXH+u2zUB93UZo+1+Ly0g23k5JtPXFbx=vaO+5-0Gw@mail.gmail.com>
2021-02-19 10:39 ` Greg KH
2021-02-19 11:52 ` Dan Carpenter [this message]
2021-02-19 12:12 ` Prakash Dubey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219115221.GW2087@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prakashdubey1999@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).