From: Vincent Guittot <vincent.guittot@linaro.org>
To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
linux-kernel@vger.kernel.org, joel@joelfernandes.org,
valentin.schneider@arm.com
Cc: fweisbec@gmail.com, tglx@linutronix.de, qais.yousef@arm.com,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: [PATCH 5/7 v4] sched/fair: reorder newidle_balance pulled_task tests
Date: Wed, 24 Feb 2021 14:30:05 +0100 [thread overview]
Message-ID: <20210224133007.28644-6-vincent.guittot@linaro.org> (raw)
In-Reply-To: <20210224133007.28644-1-vincent.guittot@linaro.org>
Reorder the tests and skip useless ones when no load balance has been
performed and rq lock has not been released.
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
---
kernel/sched/fair.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 0323fda07682..586f6ce0d302 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -10584,7 +10584,6 @@ static int newidle_balance(struct rq *this_rq, struct rq_flags *rf)
if (curr_cost > this_rq->max_idle_balance_cost)
this_rq->max_idle_balance_cost = curr_cost;
-out:
/*
* While browsing the domains, we released the rq lock, a task could
* have been enqueued in the meantime. Since we're not going idle,
@@ -10593,14 +10592,15 @@ static int newidle_balance(struct rq *this_rq, struct rq_flags *rf)
if (this_rq->cfs.h_nr_running && !pulled_task)
pulled_task = 1;
- /* Move the next balance forward */
- if (time_after(this_rq->next_balance, next_balance))
- this_rq->next_balance = next_balance;
-
/* Is there a task of a high priority class? */
if (this_rq->nr_running != this_rq->cfs.h_nr_running)
pulled_task = -1;
+out:
+ /* Move the next balance forward */
+ if (time_after(this_rq->next_balance, next_balance))
+ this_rq->next_balance = next_balance;
+
if (pulled_task)
this_rq->idle_stamp = 0;
else
--
2.17.1
next prev parent reply other threads:[~2021-02-24 14:51 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 13:30 [PATCH 0/7 v4] move update blocked load outside newidle_balance Vincent Guittot
2021-02-24 13:30 ` [PATCH 1/7 v4] sched/fair: remove update of blocked load from newidle_balance Vincent Guittot
2021-03-02 9:01 ` [tip: sched/core] sched/fair: Remove " tip-bot2 for Vincent Guittot
2021-03-03 9:49 ` tip-bot2 for Vincent Guittot
2021-03-06 11:42 ` tip-bot2 for Vincent Guittot
2021-02-24 13:30 ` [PATCH 2/7 v4] sched/fair: remove unused return of _nohz_idle_balance Vincent Guittot
2021-03-02 9:01 ` [tip: sched/core] sched/fair: Remove " tip-bot2 for Vincent Guittot
2021-03-03 9:49 ` tip-bot2 for Vincent Guittot
2021-03-06 11:42 ` tip-bot2 for Vincent Guittot
2021-02-24 13:30 ` [PATCH 3/7 v4] sched/fair: remove unused parameter of update_nohz_stats Vincent Guittot
2021-03-02 9:01 ` [tip: sched/core] sched/fair: Remove " tip-bot2 for Vincent Guittot
2021-03-03 9:49 ` tip-bot2 for Vincent Guittot
2021-03-05 13:55 ` [PATCH 3/7 v4] sched/fair: remove " Qais Yousef
2021-03-06 11:42 ` [tip: sched/core] sched/fair: Remove " tip-bot2 for Vincent Guittot
2021-02-24 13:30 ` [PATCH 4/7 v4] sched/fair: merge for each idle cpu loop of ILB Vincent Guittot
2021-03-02 9:01 ` [tip: sched/core] sched/fair: Merge " tip-bot2 for Vincent Guittot
2021-03-03 9:49 ` tip-bot2 for Vincent Guittot
2021-03-06 11:42 ` tip-bot2 for Vincent Guittot
2021-02-24 13:30 ` Vincent Guittot [this message]
2021-03-02 9:01 ` [tip: sched/core] sched/fair: Reorder newidle_balance pulled_task tests tip-bot2 for Vincent Guittot
2021-03-03 9:49 ` tip-bot2 for Vincent Guittot
2021-03-06 11:42 ` tip-bot2 for Vincent Guittot
2021-02-24 13:30 ` [PATCH 6/7 v4] sched/fair: trigger the update of blocked load on newly idle cpu Vincent Guittot
2021-03-02 9:01 ` [tip: sched/core] sched/fair: Trigger " tip-bot2 for Vincent Guittot
2021-03-03 9:49 ` tip-bot2 for Vincent Guittot
2021-03-05 13:52 ` [PATCH 6/7 v4] sched/fair: trigger " Qais Yousef
2021-03-06 11:42 ` [tip: sched/core] sched/fair: Trigger " tip-bot2 for Vincent Guittot
2021-02-24 13:30 ` [PATCH 7/7 v4] sched/fair: reduce the window for duplicated update Vincent Guittot
2021-03-02 9:01 ` [tip: sched/core] sched/fair: Reduce " tip-bot2 for Vincent Guittot
2021-03-03 9:49 ` tip-bot2 for Vincent Guittot
2021-03-06 11:42 ` tip-bot2 for Vincent Guittot
2021-02-24 15:53 ` [PATCH 0/7 v4] move update blocked load outside newidle_balance Peter Zijlstra
2021-02-24 15:57 ` Vincent Guittot
2021-02-24 17:41 ` Peter Zijlstra
2021-02-24 17:51 ` Vincent Guittot
2021-02-24 18:17 ` Peter Zijlstra
2021-02-24 18:46 ` Valentin Schneider
2021-02-25 8:05 ` Vincent Guittot
2021-02-25 12:14 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224133007.28644-6-vincent.guittot@linaro.org \
--to=vincent.guittot@linaro.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=fweisbec@gmail.com \
--cc=joel@joelfernandes.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).