From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: "Ronald Tschalär" <ronald@innovation.ch>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jonathan Cameron <jic23@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
<linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>,
<linux-iio@vger.kernel.org>
Subject: Re: [PATCH 2/5] iio: hid-sensor-als: Support change sensitivity in illuminance too.
Date: Sun, 28 Feb 2021 14:45:25 +0000 [thread overview]
Message-ID: <20210228144525.00000730@Huawei.com> (raw)
In-Reply-To: <20210228012643.69944-3-ronald@innovation.ch>
On Sat, 27 Feb 2021 17:26:40 -0800
Ronald Tschalär <ronald@innovation.ch> wrote:
> Recent MacBook Pro's specify the usage of the change sensitivity field
> as illuminance (with a change sensitivity modifier) rather than as
> light.
>
> Signed-off-by: Ronald Tschalär <ronald@innovation.ch>
This looks fine to me though it the hid sensors spec never fails to surprise
me in the different slight variants of the same thing that come up.
Illuminance is at least fairly well defined, but who knows what for the DATA_LIGHT
version takes?
Anyhow, lets give time for Srinivas to sanity check this as he's much more familiar
with that spec than I am.
Jonathan
> ---
> drivers/iio/light/hid-sensor-als.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/iio/light/hid-sensor-als.c b/drivers/iio/light/hid-sensor-als.c
> index a21c827e4953d..849ee37dcd866 100644
> --- a/drivers/iio/light/hid-sensor-als.c
> +++ b/drivers/iio/light/hid-sensor-als.c
> @@ -252,6 +252,14 @@ static int als_parse_report(struct platform_device *pdev,
> HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS |
> HID_USAGE_SENSOR_DATA_LIGHT,
> &st->common_attributes.sensitivity);
> +
> + if (st->common_attributes.sensitivity.index < 0)
> + sensor_hub_input_get_attribute_info(hsdev,
> + HID_FEATURE_REPORT, usage_id,
> + HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS |
> + HID_USAGE_SENSOR_LIGHT_ILLUM,
> + &st->common_attributes.sensitivity);
> +
> dev_dbg(&pdev->dev, "Sensitivity index:report %d:%d\n",
> st->common_attributes.sensitivity.index,
> st->common_attributes.sensitivity.report_id);
next prev parent reply other threads:[~2021-02-28 14:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-28 1:26 [PATCH 0/5] Touch Bar and ALS support for MacBook Pro's Ronald Tschalär
2021-02-28 1:26 ` [PATCH 1/5] HID: Recognize sensors with application collections too Ronald Tschalär
2021-02-28 1:26 ` [PATCH 2/5] iio: hid-sensor-als: Support change sensitivity in illuminance too Ronald Tschalär
2021-02-28 14:45 ` Jonathan Cameron [this message]
2021-03-01 17:39 ` Srinivas Pandruvada
2021-02-28 1:26 ` [PATCH 3/5] HID: core: Export some report item parsing functions Ronald Tschalär
2021-03-01 14:18 ` Andy Shevchenko
2021-03-01 14:27 ` Benjamin Tissoires
2021-02-28 1:26 ` [PATCH 4/5] HID: apple-ibridge: Add Apple iBridge HID driver for T1 chip Ronald Tschalär
2021-02-28 15:02 ` Jonathan Cameron
2021-03-01 0:04 ` Life is hard, and then you die
2021-03-01 14:12 ` Andy Shevchenko
2021-02-28 1:26 ` [PATCH 5/5] HID: apple-touchbar - Add driver for the Touch Bar on MacBook Pro's Ronald Tschalär
2021-02-28 3:52 ` kernel test robot
2021-02-28 4:16 ` kernel test robot
2021-02-28 7:37 ` kernel test robot
2021-02-28 14:38 ` [PATCH 0/5] Touch Bar and ALS support for " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210228144525.00000730@Huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=ronald@innovation.ch \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).