From: Chen Yu <yu.c.chen@intel.com>
To: Doug Smythies <dsmythies@telus.net>, youling257 <youling257@gmail.com>
Cc: youling257 <youling257@gmail.com>,
lenb@kernel.org, rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
Len Brown <len.brown@intel.com>, Chen Yu <yu.c.chen@intel.com>
Subject: Re: [3/3,v3] tools/power turbostat: Enable accumulate RAPL display
Date: Tue, 9 Mar 2021 00:15:48 +0800 [thread overview]
Message-ID: <20210308161548.GA37664@chenyu-desktop> (raw)
In-Reply-To: <CAAYoRsXec2eq=t-pSn5TOqNt0G6kfZCKkDuEhCnX5SgL0zgkBg@mail.gmail.com>
Hi,
On Mon, Mar 08, 2021 at 07:37:07AM -0800, Doug Smythies wrote:
> On Mon, Mar 8, 2021 at 5:50 AM youling257 <youling257@gmail.com> wrote:
> >
> > this cause turbostat not work on amd cpu.
> >
> > root@localhost:~# /turbostat
> > turbostat version 20.09.30 - Len Brown <lenb@kernel.org>
> > CPUID(0): AuthenticAMD 0xd CPUID levels; 0x8000001f xlevels; family:model:stepping 0x17:18:1 (23:24:1)
>
> There are already two fixes for this in the queue.
> https://marc.info/?l=linux-pm&m=161382097503925&w=2
> https://marc.info/?l=linux-pm&m=161141701219263&w=2
Thanks for reporting and pointing this out. I assume these two patches are both fixing the
same issue? It looks like these two patches should be merged into one:
1. Bingsong's patch access MSR_PKG_ENERGY_STAT only when RAPL_AMD_F17H is set,
which is consistent with the original context.
2. Bas Nieuwenhuizen's patch also fixes the issue in idx_valid()
in case RAPL_PKG was not set but with RAPL_AMD_F17H set.
thanks,
Chenyu
next prev parent reply other threads:[~2021-03-08 16:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 8:31 [PATCH 0/3][v3] tools/power turbostat: Enable accumulated energy consumption for long time sampling Chen Yu
2020-04-18 8:31 ` [PATCH 1/3][v3] tools/power turbostat: Make the energy variable to be 64 bit Chen Yu
2020-04-18 8:31 ` [PATCH 2/3][v3] tools/power turbostat: Introduce functions to accumulate RAPL consumption Chen Yu
2020-04-18 8:32 ` [PATCH 3/3][v3] tools/power turbostat: Enable accumulate RAPL display Chen Yu
2021-03-08 13:49 ` [3/3,v3] " youling257
2021-03-08 15:37 ` Doug Smythies
2021-03-08 16:15 ` Chen Yu [this message]
2021-03-11 0:03 ` Doug Smythies
2021-03-12 12:17 ` Chen Yu
2021-03-12 13:41 ` Chen Yu
2021-03-13 13:49 ` youling 257
2021-03-24 14:44 ` Doug Smythies
2021-03-24 15:55 ` Christian Kastner
2021-03-25 12:12 ` Kurt Garloff
2021-03-26 2:14 ` sibingsong
2021-04-24 1:43 ` Chen Yu
2021-04-24 10:50 ` Bas Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308161548.GA37664@chenyu-desktop \
--to=yu.c.chen@intel.com \
--cc=dsmythies@telus.net \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=youling257@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).