From: Viresh Kumar <viresh.kumar@linaro.org>
To: Sergei Trofimovich <slyfox@gentoo.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH] ia64: fix format string for ia64-acpi-cpu-freq
Date: Mon, 15 Mar 2021 08:49:13 +0530 [thread overview]
Message-ID: <20210315031913.icgekcdrbw4clikm@vireshk-i7> (raw)
In-Reply-To: <20210313104214.1548076-1-slyfox@gentoo.org>
On 13-03-21, 10:42, Sergei Trofimovich wrote:
> Fix warning with %lx / s64 mismatch:
>
> CC [M] drivers/cpufreq/ia64-acpi-cpufreq.o
> drivers/cpufreq/ia64-acpi-cpufreq.c: In function 'processor_get_pstate':
> warning: format '%lx' expects argument of type 'long unsigned int',
> but argument 3 has type 's64' {aka 'long long int'} [-Wformat=]
>
> CC: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> CC: Viresh Kumar <viresh.kumar@linaro.org>
> CC: linux-pm@vger.kernel.org
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
> drivers/cpufreq/ia64-acpi-cpufreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/ia64-acpi-cpufreq.c b/drivers/cpufreq/ia64-acpi-cpufreq.c
> index 2efe7189ccc4..c6bdc455517f 100644
> --- a/drivers/cpufreq/ia64-acpi-cpufreq.c
> +++ b/drivers/cpufreq/ia64-acpi-cpufreq.c
> @@ -54,7 +54,7 @@ processor_set_pstate (
> retval = ia64_pal_set_pstate((u64)value);
>
> if (retval) {
> - pr_debug("Failed to set freq to 0x%x, with error 0x%lx\n",
> + pr_debug("Failed to set freq to 0x%x, with error 0x%llx\n",
> value, retval);
> return -ENODEV;
> }
> @@ -77,7 +77,7 @@ processor_get_pstate (
>
> if (retval)
> pr_debug("Failed to get current freq with "
> - "error 0x%lx, idx 0x%x\n", retval, *value);
> + "error 0x%llx, idx 0x%x\n", retval, *value);
>
> return (int)retval;
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2021-03-15 3:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-13 10:42 [PATCH] ia64: fix format string for ia64-acpi-cpu-freq Sergei Trofimovich
2021-03-15 3:19 ` Viresh Kumar [this message]
2021-03-19 16:27 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315031913.icgekcdrbw4clikm@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=slyfox@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).