From: Robert Foss <robert.foss@linaro.org>
To: robert.foss@linaro.org, todor.too@gmail.com, agross@kernel.org,
bjorn.andersson@linaro.org, mchehab@kernel.org,
robh+dt@kernel.org, angelogioacchino.delregno@somainline.org,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
AngeloGioacchino Del Regno <kholk11@gmail.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
Andrey Konovalov <andrey.konovalov@linaro.org>,
Hans Verkuil <hverkuil@xs4all.nl>
Cc: Rob Herring <robh@kernel.org>, Tomasz Figa <tfiga@chromium.org>,
Azam Sadiq Pasha Kapatrala Syed <akapatra@quicinc.com>,
Sarvesh Sridutt <Sarvesh.Sridutt@smartwirelesscompute.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jonathan Marek <jonathan@marek.ca>,
Nicolas Boichat <drinkcat@chromium.org>
Subject: [PATCH v9 03/22] media: camss: Replace trace_printk() with dev_dbg()
Date: Tue, 16 Mar 2021 18:19:12 +0100 [thread overview]
Message-ID: <20210316171931.812748-4-robert.foss@linaro.org> (raw)
In-Reply-To: <20210316171931.812748-1-robert.foss@linaro.org>
trace_printk() should not be used in production code,
since extra memory is used for special buffers whenever
trace_puts() is used.
Replace it with dev_dbg() which provides all of the desired
debugging functionality.
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Suggested-by: Nicolas Boichat <drinkcat@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
---
Changes since v3:
- Nicolas: Create this patch
Changes since v4:
- Nicolas: Add r-b
drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 5 +++--
drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
index a1b56b89130d..85b9bcbc7321 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c
@@ -12,6 +12,7 @@
#include <linux/io.h>
#include <linux/iopoll.h>
+#include "camss.h"
#include "camss-vfe.h"
#define VFE_0_HW_VERSION 0x000
@@ -936,8 +937,8 @@ static irqreturn_t vfe_isr(int irq, void *dev)
vfe->ops->isr_read(vfe, &value0, &value1);
- trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n",
- value0, value1);
+ dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n",
+ value0, value1);
if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK)
vfe->isr_ops.reset_ack(vfe);
diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
index 84c33b8f9fe3..f7e00a2de393 100644
--- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
+++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c
@@ -12,6 +12,7 @@
#include <linux/io.h>
#include <linux/iopoll.h>
+#include "camss.h"
#include "camss-vfe.h"
#define VFE_0_HW_VERSION 0x000
@@ -1069,8 +1070,8 @@ static irqreturn_t vfe_isr(int irq, void *dev)
vfe->ops->isr_read(vfe, &value0, &value1);
- trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n",
- value0, value1);
+ dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n",
+ value0, value1);
if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK)
vfe->isr_ops.reset_ack(vfe);
--
2.27.0
next prev parent reply other threads:[~2021-03-16 17:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 17:19 [PATCH v9 00/22] Add support for the SDM845 Camera Subsystem Robert Foss
2021-03-16 17:19 ` [PATCH v9 01/22] media: camss: Fix vfe_isr_comp_done() documentation Robert Foss
2021-03-16 17:19 ` [PATCH v9 02/22] media: camss: Fix vfe_isr comment typo Robert Foss
2021-03-16 17:19 ` Robert Foss [this message]
2021-03-16 17:19 ` [PATCH v9 04/22] media: camss: Add CAMSS_845 camss version Robert Foss
2021-03-16 17:19 ` [PATCH v9 05/22] media: camss: Make ISPIF subdevice optional Robert Foss
2021-03-16 17:19 ` [PATCH v9 06/22] media: camss: Refactor VFE HW version support Robert Foss
2021-03-16 17:19 ` [PATCH v9 07/22] media: camss: Add support for VFE hardware version Titan 170 Robert Foss
2021-03-16 17:19 ` [PATCH v9 08/22] media: camss: Add missing format identifiers Robert Foss
2021-03-16 17:19 ` [PATCH v9 09/22] media: camss: Refactor CSID HW version support Robert Foss
2021-03-16 17:19 ` [PATCH v9 10/22] media: camss: Add support for CSID hardware version Titan 170 Robert Foss
2021-03-16 17:19 ` [PATCH v9 11/22] media: camss: Add support for CSIPHY " Robert Foss
2021-03-16 17:19 ` [PATCH v9 12/22] media: camss: Refactor VFE power domain toggling Robert Foss
2021-03-16 17:19 ` [PATCH v9 13/22] media: camss: Enable SDM845 Robert Foss
2021-03-16 17:19 ` [PATCH v9 14/22] dt-bindings: media: camss: Add qcom,msm8916-camss binding Robert Foss
2021-03-16 17:19 ` [PATCH v9 15/22] dt-bindings: media: camss: Add qcom,msm8996-camss binding Robert Foss
2021-03-16 17:19 ` [PATCH v9 16/22] dt-bindings: media: camss: Add qcom,sdm660-camss binding Robert Foss
2021-03-16 17:19 ` [PATCH v9 17/22] dt-bindings: media: camss: Add qcom,sdm845-camss binding Robert Foss
2021-03-16 17:19 ` [PATCH v9 18/22] MAINTAINERS: Change CAMSS documentation to use dtschema bindings Robert Foss
2021-03-16 17:19 ` [PATCH v9 19/22] media: dt-bindings: media: Remove qcom,camss documentation Robert Foss
2021-03-16 17:19 ` [PATCH v9 20/22] arm64: dts: sdm845: Add CAMSS ISP node Robert Foss
2021-03-16 17:19 ` [PATCH v9 21/22] arm64: dts: sdm845-db845c: Configure regulators for camss node Robert Foss
2021-03-16 17:19 ` [PATCH v9 22/22] arm64: dts: sdm845-db845c: Enable ov8856 sensor and connect to ISP Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210316171931.812748-4-robert.foss@linaro.org \
--to=robert.foss@linaro.org \
--cc=Sarvesh.Sridutt@smartwirelesscompute.com \
--cc=agross@kernel.org \
--cc=akapatra@quicinc.com \
--cc=andrey.konovalov@linaro.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=hverkuil@xs4all.nl \
--cc=jonathan@marek.ca \
--cc=kholk11@gmail.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=tfiga@chromium.org \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).