From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: x86@kernel.org, jgross@suse.com, mbenes@suze.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/9] objtool: Rework rebuild_reloc logic
Date: Wed, 17 Mar 2021 19:49:17 -0500 [thread overview]
Message-ID: <20210318004917.sytcivxy5h2ujttc@treble> (raw)
In-Reply-To: <YFG53wkgw6nDBgIl@hirez.programming.kicks-ass.net>
On Wed, Mar 17, 2021 at 09:12:15AM +0100, Peter Zijlstra wrote:
> On Tue, Mar 16, 2021 at 10:34:17PM -0500, Josh Poimboeuf wrote:
> > On Fri, Mar 12, 2021 at 06:16:18PM +0100, Peter Zijlstra wrote:
> > > --- a/tools/objtool/elf.c
> > > +++ b/tools/objtool/elf.c
> > > @@ -479,6 +479,8 @@ void elf_add_reloc(struct elf *elf, stru
> > >
> > > list_add_tail(&reloc->list, &sec->reloc_list);
> > > elf_hash_add(elf->reloc_hash, &reloc->hash, reloc_hash(reloc));
> > > +
> > > + sec->rereloc = true;
> > > }
> >
> > Can we just reuse sec->changed for this? Something like this on top
> > (untested of course):
>
> I think my worry was that we'd dirty too much and slow down the write,
> but I haven't done any actual performance measurements on this.
Really? I thought my proposal was purely aesthetic, no functional
change, but my brain is toasty this week due to other distractions so
who knows.
> Let me do a few runs and see if it matters at all.
--
Josh
next prev parent reply other threads:[~2021-03-18 0:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 17:16 [PATCH 0/9] x86,objtool: Optimize !RETPOLINE Peter Zijlstra
2021-03-12 17:16 ` [PATCH 1/9] x86/retpoline: Simplify retpolines Peter Zijlstra
2021-03-12 17:16 ` [PATCH 2/9] objtool: Correctly handle retpoline thunk calls Peter Zijlstra
2021-03-16 21:19 ` Josh Poimboeuf
2021-03-12 17:16 ` [PATCH 3/9] objtool: Per arch retpoline naming Peter Zijlstra
2021-03-12 17:16 ` [PATCH 4/9] objtool: Fix static_call list generation Peter Zijlstra
2021-03-17 3:18 ` Josh Poimboeuf
2021-03-12 17:16 ` [PATCH 5/9] objtool: Rework rebuild_reloc logic Peter Zijlstra
2021-03-17 3:34 ` Josh Poimboeuf
2021-03-17 8:12 ` Peter Zijlstra
2021-03-18 0:49 ` Josh Poimboeuf [this message]
2021-03-18 12:57 ` Peter Zijlstra
2021-03-18 16:36 ` Josh Poimboeuf
2021-03-18 17:04 ` Peter Zijlstra
2021-03-18 17:38 ` Josh Poimboeuf
2021-03-19 0:19 ` Josh Poimboeuf
2021-03-19 9:22 ` Peter Zijlstra
2021-03-19 15:15 ` Josh Poimboeuf
2021-03-12 17:16 ` [PATCH 6/9] objtool: Add elf_create_undef_symbol() Peter Zijlstra
2021-03-17 13:52 ` Miroslav Benes
2021-03-17 14:13 ` Peter Zijlstra
2021-03-17 14:39 ` Miroslav Benes
2021-03-17 15:08 ` Sami Tolvanen
2021-03-18 0:46 ` Josh Poimboeuf
2021-03-18 7:56 ` Peter Zijlstra
2021-03-12 17:16 ` [PATCH 7/9] objtool: Allow archs to rewrite retpolines Peter Zijlstra
2021-03-12 17:16 ` [PATCH 8/9] objtool: Skip magical retpoline .altinstr_replacement Peter Zijlstra
2021-03-12 17:16 ` [PATCH 9/9] objtool,x86: Rewrite retpoline thunk calls Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318004917.sytcivxy5h2ujttc@treble \
--to=jpoimboe@redhat.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suze.cz \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).