Hi Jens, I love your patch! Yet something to improve: [auto build test ERROR on linux/master] [also build test ERROR on tip/sched/core linus/master v5.12-rc3 next-20210319] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Jens-Axboe/PF_IO_WORKER-signal-tweaks/20210320-234247 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git a74e6a014c9d4d4161061f770c9b4f98372ac778 config: openrisc-randconfig-r026-20210321 (attached as .config) compiler: or1k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/05c70f370b93f3bf555e63293d43a82aab2fcdf3 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Jens-Axboe/PF_IO_WORKER-signal-tweaks/20210320-234247 git checkout 05c70f370b93f3bf555e63293d43a82aab2fcdf3 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/linux/ptrace.h:7, from arch/openrisc/kernel/asm-offsets.c:28: include/linux/sched/signal.h: In function 'same_thread_group_account': >> include/linux/sched/signal.h:673:33: error: expected ';' before '}' token 673 | return p1->signal == p2->signal | ^ | ; 674 | } | ~ -- In file included from include/linux/ptrace.h:7, from arch/openrisc/kernel/asm-offsets.c:28: include/linux/sched/signal.h: In function 'same_thread_group_account': >> include/linux/sched/signal.h:673:33: error: expected ';' before '}' token 673 | return p1->signal == p2->signal | ^ | ; 674 | } | ~ make[2]: *** [scripts/Makefile.build:116: arch/openrisc/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1233: prepare0] Error 2 make[1]: Target 'modules_prepare' not remade because of errors. make: *** [Makefile:215: __sub-make] Error 2 make: Target 'modules_prepare' not remade because of errors. -- In file included from include/linux/ptrace.h:7, from arch/openrisc/kernel/asm-offsets.c:28: include/linux/sched/signal.h: In function 'same_thread_group_account': >> include/linux/sched/signal.h:673:33: error: expected ';' before '}' token 673 | return p1->signal == p2->signal | ^ | ; 674 | } | ~ make[2]: *** [scripts/Makefile.build:116: arch/openrisc/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1233: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:215: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +673 include/linux/sched/signal.h 669 670 static inline 671 bool same_thread_group_account(struct task_struct *p1, struct task_struct *p2) 672 { > 673 return p1->signal == p2->signal 674 } 675 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org