From: Steven Rostedt <rostedt@goodmis.org>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"John (Warthog9) Hawley" <warthog9@kernel.org>
Subject: Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users
Date: Thu, 25 Mar 2021 09:50:39 -0400 [thread overview]
Message-ID: <20210325095039.7202d675@gandalf.local.home> (raw)
In-Reply-To: <CAK7LNAQ4uRB+9M4h0KVwEQUnX1XZrsE30KP_pqJqYjF2FcsHZA@mail.gmail.com>
On Thu, 25 Mar 2021 15:20:13 +0900
Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> The root cause of inconsistency is that
> you mix up space-indentation and tab-indentation.
> I do not know if it is a standard way either.
This is the default way emacs has edited perl files for as long as I can
remember (back to 1996). It became my standard of editing perl files just
because of that. For everything else, I use tabs.
>
> For example, scripts/checkpatch.pl uses only tabs,
> which I think is more robust.
Probably because Joe probably uses vim ;-)
>
> Unfortunately, we do not have standardized indentation style
> for scripts yet, and people can go in any direction.
>
> The editorconfig patch [1] proposed to always use 4-space
> indentation for *.pl files.
> (that is, do not replace 8 spaces with a tab).
I rather have all tabs, or the tab and spaces. I find 8 spaces to be a
waste of memory and disk space.
>
> I do not know whether the kernel will adopt .editorconfig or not,
> but if that patch is applied, your 1/2 will be a step backward.
My 1/2 only made it consistent, as the original code had the tab/spaces mix
and just a few lines that were modified by others broke it by adding all
spaces.
>
> My got-feeling is, you will never reach the goal as long as
> you adopt a strange indentation style, which is obscure
> to other contributors.
I'm guessing this is not strange to other perl developers who uses emacs.
>
> Not all people use vim.
I don't use it either. I was trying to make vim match emacs. Of course for
those that use something else, it wont help. I'm curious, what's your main
editor that you use?
> I am not interested in 1/2 either.
OK.
>
> If you insist on this patch set, apply it to your tree
> and send a pull request by yourself.
I'm fine with that.
>
>
> [1]: https://lore.kernel.org/lkml/20200703073143.423557-1-danny@kdrag0n.dev/
Thanks for the link.
-- Steve
next prev parent reply other threads:[~2021-03-25 13:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 21:38 [PATCH 0/2] streamline_config.pl: Fix Perl spacing Steven Rostedt
2021-03-22 21:38 ` [PATCH 1/2] streamline_config.pl: Make spacing consistent Steven Rostedt
2021-03-22 21:38 ` [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users Steven Rostedt
2021-03-24 6:01 ` Masahiro Yamada
2021-03-24 13:54 ` Steven Rostedt
2021-03-25 0:06 ` Steven Rostedt
2021-03-25 6:20 ` Masahiro Yamada
2021-03-25 13:50 ` Steven Rostedt [this message]
2021-03-25 14:09 ` Masahiro Yamada
2021-03-25 15:10 ` Steven Rostedt
2021-03-26 7:51 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325095039.7202d675@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).