From: Viresh Kumar <viresh.kumar@linaro.org>
To: "Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
srv_heupstream@mediatek.com
Subject: Re: [PATCH V8 2/8] cpufreq: mediatek: Enable clock and regulator
Date: Tue, 30 Mar 2021 10:06:29 +0530 [thread overview]
Message-ID: <20210330043629.x62j2apv2nv4mw67@vireshk-i7> (raw)
In-Reply-To: <1616499241-4906-3-git-send-email-andrew-sh.cheng@mediatek.com>
On 23-03-21, 19:33, Andrew-sh.Cheng wrote:
> From: "Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com>
>
> Need to enable regulator,
> so that the max/min requested value will be recorded
> even it is not applied right away.
>
> Intermediate clock is not always enabled by ccf in different projects,
> so cpufreq should enable it by itself.
>
> Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com>
> ---
> drivers/cpufreq/mediatek-cpufreq.c | 33 +++++++++++++++++++++++++++++----
> 1 file changed, 29 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> index f2e491b25b07..432368707ea6 100644
> --- a/drivers/cpufreq/mediatek-cpufreq.c
> +++ b/drivers/cpufreq/mediatek-cpufreq.c
> @@ -350,6 +350,11 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
> ret = PTR_ERR(proc_reg);
> goto out_free_resources;
> }
> + ret = regulator_enable(proc_reg);
> + if (ret) {
> + pr_warn("enable vproc for cpu%d fail\n", cpu);
> + goto out_free_resources;
> + }
Regulators are enabled by OPP core as well now, you sure this is
required ?
--
viresh
next prev parent reply other threads:[~2021-03-30 4:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1616499241-4906-1-git-send-email-andrew-sh.cheng@mediatek.com>
[not found] ` <CGME20210323113411epcas1p3b4367563007ca91c30201d7fc225bb67@epcas1p3.samsung.com>
[not found] ` <1616499241-4906-2-git-send-email-andrew-sh.cheng@mediatek.com>
2021-03-25 7:42 ` [PATCH V8 1/8] PM / devfreq: Add cpu based scaling support to passive_governor Chanwoo Choi
2021-03-25 8:14 ` Chanwoo Choi
[not found] ` <1617177820.15067.1.camel@mtksdaap41>
2021-03-31 8:27 ` Chanwoo Choi
2021-03-31 8:35 ` Chanwoo Choi
[not found] ` <1617195800.18432.3.camel@mtksdaap41>
2021-04-01 0:16 ` Chanwoo Choi
2021-04-08 2:47 ` Chanwoo Choi
[not found] ` <1621995727.29827.1.camel@mtksdaap41>
2021-05-26 3:08 ` Chanwoo Choi
[not found] ` <1622431376.14423.5.camel@mtksdaap41>
2021-05-31 7:56 ` Chanwoo Choi
[not found] ` <CACb=7PUkpMkDOJ6dDHXhJ5ep4e9u8ZVYM8M2iC-iwHXn13t3DQ@mail.gmail.com>
2021-05-31 8:13 ` Chanwoo Choi
2021-03-31 10:46 ` Hsin-Yi Wang
[not found] ` <CGME20210323113411epcas1p3dcc8649a2e3bed66866e3470d7aab447@epcas1p3.samsung.com>
[not found] ` <1616499241-4906-5-git-send-email-andrew-sh.cheng@mediatek.com>
2021-03-25 8:04 ` [PATCH V8 4/8] devfreq: add mediatek cci devfreq Chanwoo Choi
[not found] ` <CGME20210323113413epcas1p1d3acc9ac2539da96b0757a0159bdcfc7@epcas1p1.samsung.com>
[not found] ` <1616499241-4906-8-git-send-email-andrew-sh.cheng@mediatek.com>
2021-03-25 8:11 ` [PATCH V8 7/8] devfreq: mediatek: cci devfreq register opp notification for SVS support Chanwoo Choi
[not found] ` <1616499241-4906-3-git-send-email-andrew-sh.cheng@mediatek.com>
2021-03-30 4:36 ` Viresh Kumar [this message]
[not found] ` <1617168099.18405.8.camel@mtksdaap41>
2021-03-31 6:17 ` [PATCH V8 2/8] cpufreq: mediatek: Enable clock and regulator Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330043629.x62j2apv2nv4mw67@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=andrew-sh.cheng@mediatek.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).