From: Stephen Boyd <swboyd@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jessica Yu <jeyu@kernel.org>,
Evan Green <evgreen@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>
Subject: [PATCH v4 11/13] buildid: Mark some arguments const
Date: Fri, 9 Apr 2021 18:52:58 -0700 [thread overview]
Message-ID: <20210410015300.3764485-12-swboyd@chromium.org> (raw)
In-Reply-To: <20210410015300.3764485-1-swboyd@chromium.org>
These arguments are never modified so they can be marked const to
indicate as such.
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Jessica Yu <jeyu@kernel.org>
Cc: Evan Green <evgreen@chromium.org>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
lib/buildid.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/buildid.c b/lib/buildid.c
index 1103ed46214f..df42282b36ff 100644
--- a/lib/buildid.c
+++ b/lib/buildid.c
@@ -48,10 +48,10 @@ static int parse_build_id_buf(unsigned char *build_id,
return -EINVAL;
}
-static inline int parse_build_id(void *page_addr,
+static inline int parse_build_id(const void *page_addr,
unsigned char *build_id,
__u32 *size,
- void *note_start,
+ const void *note_start,
Elf32_Word note_size)
{
/* check for overflow */
@@ -66,7 +66,7 @@ static inline int parse_build_id(void *page_addr,
}
/* Parse build ID from 32-bit ELF */
-static int get_build_id_32(void *page_addr, unsigned char *build_id,
+static int get_build_id_32(const void *page_addr, unsigned char *build_id,
__u32 *size)
{
Elf32_Ehdr *ehdr = (Elf32_Ehdr *)page_addr;
@@ -91,7 +91,7 @@ static int get_build_id_32(void *page_addr, unsigned char *build_id,
}
/* Parse build ID from 64-bit ELF */
-static int get_build_id_64(void *page_addr, unsigned char *build_id,
+static int get_build_id_64(const void *page_addr, unsigned char *build_id,
__u32 *size)
{
Elf64_Ehdr *ehdr = (Elf64_Ehdr *)page_addr;
--
https://chromeos.dev
next prev parent reply other threads:[~2021-04-10 1:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 1:52 [PATCH v4 00/13] Add build ID to stacktraces Stephen Boyd
2021-04-10 1:52 ` [PATCH v4 01/13] buildid: Only consider GNU notes for build ID parsing Stephen Boyd
2021-04-13 14:34 ` Petr Mladek
2021-04-10 1:52 ` [PATCH v4 02/13] buildid: Add API to parse build ID out of buffer Stephen Boyd
2021-04-10 1:52 ` [PATCH v4 03/13] buildid: Stash away kernels build ID on init Stephen Boyd
2021-04-10 1:52 ` [PATCH v4 04/13] dump_stack: Add vmlinux build ID to stack traces Stephen Boyd
2021-04-13 14:41 ` Petr Mladek
2021-04-13 20:36 ` Stephen Boyd
2021-04-10 1:52 ` [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces Stephen Boyd
2021-04-12 11:58 ` Andy Shevchenko
2021-04-12 19:29 ` Stephen Boyd
2021-04-13 10:56 ` Andy Shevchenko
2021-04-13 15:16 ` Petr Mladek
2021-04-13 20:10 ` Stephen Boyd
2021-04-13 22:36 ` Stephen Boyd
2021-04-13 15:01 ` Petr Mladek
2021-04-13 22:57 ` Stephen Boyd
2021-04-15 8:53 ` Petr Mladek
2021-04-15 13:04 ` Jessica Yu
2021-04-18 1:52 ` Stephen Boyd
2021-04-19 10:34 ` Jessica Yu
2021-04-10 1:52 ` [PATCH v4 06/13] arm64: stacktrace: Use %pSb for backtrace printing Stephen Boyd
2021-04-10 1:52 ` [PATCH v4 07/13] x86/dumpstack: Use %pSb/%pBb " Stephen Boyd
2021-04-10 1:52 ` [PATCH v4 08/13] scripts/decode_stacktrace.sh: Support debuginfod Stephen Boyd
2021-04-10 1:52 ` [PATCH v4 09/13] scripts/decode_stacktrace.sh: Silence stderr messages from addr2line/nm Stephen Boyd
2021-04-10 1:52 ` [PATCH v4 10/13] scripts/decode_stacktrace.sh: Indicate 'auto' can be used for base path Stephen Boyd
2021-04-10 1:52 ` Stephen Boyd [this message]
2021-04-10 1:52 ` [PATCH v4 12/13] buildid: Fix kernel-doc notation Stephen Boyd
2021-04-10 1:53 ` [PATCH v4 13/13] kdump: Use vmlinux_build_id to simplify Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210410015300.3764485-12-swboyd@chromium.org \
--to=swboyd@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=evgreen@chromium.org \
--cc=hsinyi@chromium.org \
--cc=jeyu@kernel.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).