From: Christoph Hellwig <hch@infradead.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Enrico Granata <egranata@google.com>,
jasowang@redhat.com, pbonzini@redhat.com, axboe@kernel.dk,
virtualization@lists.linux-foundation.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_blk: Add support for lifetime feature
Date: Thu, 15 Apr 2021 16:54:11 +0100 [thread overview]
Message-ID: <20210415155411.GA2090820@infradead.org> (raw)
In-Reply-To: <20210412074309-mutt-send-email-mst@kernel.org>
On Mon, Apr 12, 2021 at 08:00:24AM -0400, Michael S. Tsirkin wrote:
> On Mon, Apr 12, 2021 at 10:42:17AM +0100, Christoph Hellwig wrote:
> > A note to the virtio committee: eMMC is the worst of all the currently
> > active storage standards by a large margin. It defines very strange
> > ad-hoc interfaces that expose very specific internals and often provides
> > very poor abstractions.
>
> Are we talking about the lifetime feature here? UFS has it too right?
Ok, the wide margin above ignores UFS, which has a lot of the same
issues as EMMC, just a little less cruft.
> It's not too late to
> change things if necessary... it would be great if you could provide
> more of the feedback on this on the TC mailing list.
I think the big main issue here is that it just forwards an awkwardly
specific concept through virtio. If we want a virtio feature it really
needs to stand a lone and be properly documented without referring to
external specifications that are not openly available.
> > It would be great it you could reach out to the
> > wider storage community before taking bad ideas from the eMMC standard
> > and putting it into virtio.
>
> Noted. It would be great if we had more representation from the storage
> community ... meanwhile what would a good forum for this be?
> linux-block@vger.kernel.org ?
At least for linux, yes.
next prev parent reply other threads:[~2021-04-15 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 23:16 [PATCH] virtio_blk: Add support for lifetime feature Enrico Granata
2021-04-12 9:17 ` Stefan Hajnoczi
2021-04-12 9:42 ` Christoph Hellwig
2021-04-12 12:00 ` Michael S. Tsirkin
2021-04-15 15:54 ` Christoph Hellwig [this message]
2021-04-14 8:44 ` Stefan Hajnoczi
2021-04-14 20:12 ` Enrico Granata
2021-04-15 15:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415155411.GA2090820@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=egranata@google.com \
--cc=jasowang@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).