From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21C3AC43460 for ; Wed, 21 Apr 2021 13:16:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ED13E61451 for ; Wed, 21 Apr 2021 13:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242632AbhDUNPb (ORCPT ); Wed, 21 Apr 2021 09:15:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:49250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242049AbhDUNJp (ORCPT ); Wed, 21 Apr 2021 09:09:45 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E6FF36143B; Wed, 21 Apr 2021 13:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1619010552; bh=n8p7gmoBMGxYaYDIWV+TarqBdxopoMWdbljAJqiCndA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=by83PEflAD5OKbW5Z+zeJ5SGcVa+COi+kHkNRNgtss8PJvbOrpHHILXe2Ue6uTPGZ rZLY9B3+x87domz6AL39mi32pkLVY9tyhChMbJpzL5/fZY4gbkzsAYuqVDzUXfeSAi JxT8k83ycNA4kCCVZjhaVZXSpSPnub4NfdwGTWzc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Aditya Pakki , Kirill Tkhai , "David S . Miller" Subject: [PATCH 176/190] Revert "net/net_namespace: Check the return value of register_pernet_subsys()" Date: Wed, 21 Apr 2021 15:00:51 +0200 Message-Id: <20210421130105.1226686-177-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210421130105.1226686-1-gregkh@linuxfoundation.org> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 0eb987c874dc93f9c9d85a6465dbde20fdd3884c. Commits from @umn.edu addresses have been found to be submitted in "bad faith" to try to test the kernel community's ability to review "known malicious" changes. The result of these submissions can be found in a paper published at the 42nd IEEE Symposium on Security and Privacy entitled, "Open Source Insecurity: Stealthily Introducing Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University of Minnesota) and Kangjie Lu (University of Minnesota). Because of this, all submissions from this group must be reverted from the kernel tree and will need to be re-reviewed again to determine if they actually are a valid fix. Until that work is complete, remove this change to ensure that no problems are being introduced into the codebase. Cc: Aditya Pakki Cc: Kirill Tkhai Cc: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/core/net_namespace.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index 43b6ac4c4439..9ae0b275238e 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.c @@ -1101,8 +1101,7 @@ static int __init net_ns_init(void) init_net_initialized = true; up_write(&pernet_ops_rwsem); - if (register_pernet_subsys(&net_ns_ops)) - panic("Could not register network namespace subsystems"); + register_pernet_subsys(&net_ns_ops); rtnl_register(PF_UNSPEC, RTM_NEWNSID, rtnl_net_newid, NULL, RTNL_FLAG_DOIT_UNLOCKED); -- 2.31.1