From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94473C433ED for ; Thu, 29 Apr 2021 20:01:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BBF1613DC for ; Thu, 29 Apr 2021 20:01:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237019AbhD2UCD convert rfc822-to-8bit (ORCPT ); Thu, 29 Apr 2021 16:02:03 -0400 Received: from jabberwock.ucw.cz ([46.255.230.98]:51970 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238445AbhD2UBh (ORCPT ); Thu, 29 Apr 2021 16:01:37 -0400 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id ED5E11C0BA5; Thu, 29 Apr 2021 22:00:49 +0200 (CEST) Date: Thu, 29 Apr 2021 22:00:49 +0200 From: Pavel Machek To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Qiushi Wu , Hans Verkuil , Mauro Carvalho Chehab Subject: Re: [PATCH 003/190] Revert "media: sti: Fix reference count leaks" Message-ID: <20210429200049.GA1175@bug> References: <20210421130105.1226686-1-gregkh@linuxfoundation.org> <20210421130105.1226686-4-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20210421130105.1226686-4-gregkh@linuxfoundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2021-04-21 14:57:58, Greg Kroah-Hartman wrote: > This reverts commit 6f4432bae9f2d12fc1815b5e26cc07e69bcad0df. > > Commits from @umn.edu addresses have been found to be submitted in "bad > faith" to try to test the kernel community's ability to review "known > malicious" changes. The result of these submissions can be found in a > paper published at the 42nd IEEE Symposium on Security and Privacy > entitled, "Open Source Insecurity: Stealthily Introducing > Vulnerabilities via Hypocrite Commits" written by Qiushi Wu (University > of Minnesota) and Kangjie Lu (University of Minnesota). > > Because of this, all submissions from this group must be reverted from > the kernel tree and will need to be re-reviewed again to determine if > they actually are a valid fix. Until that work is complete, remove this > change to ensure that no problems are being introduced into the > codebase. NAK. This fixes minor bug and should not be reverted. Pavel > @@ -272,7 +272,6 @@ static unsigned long int hva_hw_get_ip_version(struct hva_dev *hva) > > if (pm_runtime_get_sync(dev) < 0) { > dev_err(dev, "%s failed to get pm_runtime\n", HVA_PREFIX); > - pm_runtime_put_noidle(dev); > mutex_unlock(&hva->protect_mutex); > return -EFAULT; > } > @@ -555,7 +554,6 @@ void hva_hw_dump_regs(struct hva_dev *hva, struct seq_file *s) > > if (pm_runtime_get_sync(dev) < 0) { > seq_puts(s, "Cannot wake up IP\n"); > - pm_runtime_put_noidle(dev); > mutex_unlock(&hva->protect_mutex); > return; > } -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html